Skip to content

Don't rebuild default targets without --force #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idbrii wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't rebuild default targets without --force #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions makelove/makelove.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def get_build_log_path(build_directory):
return os.path.join(build_directory, ".makelove-buildlog")


def prepare_build_directory(args, config, version):
def prepare_build_directory(args, config, version, targets):
assert "build_directory" in config
build_directory = config["build_directory"]
versioned_build = version != None
Expand All @@ -67,7 +67,7 @@ def prepare_build_directory(args, config, version):
if os.path.isdir(build_directory):
# If no version is specified, overwrite by default
built_targets = os.listdir(build_directory)
building_target_again = any(target in built_targets for target in args.targets)
building_target_again = any(target in built_targets for target in targets)
# If the targets being built have not been built before, it should be fine to not do anything
# The deletion/creation of the target directories is handled in main() (they are just deleted if they exist).
if versioned_build and building_target_again and not args.force:
Expand Down Expand Up @@ -281,10 +281,10 @@ def main():
print("Exiting because --check was passed.")
sys.exit(0)

build_directory = prepare_build_directory(args, config, version)

targets = get_targets(args, config)

build_directory = prepare_build_directory(args, config, version, targets)

if sys.platform.startswith("win") and "appimage" in targets:
sys.exit("Currently AppImages can only be built on Linux and WSL2!")

Expand Down