Rafaelpadilla/renaming variables with meaningful names #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ution. Made changes in some parts of the code for mypy checks
`Closes #3`: Use `|` syntax instead of `Optional`/`Union`
Lint + Mypy fixes
`Closes PR#9`: Use pathlib.Path in place of os.path for modern path management.
…#40) * Backward compatibility for the ThreeWChart visualization class * Fixing and formatting parts of the code. * Format code with Black. * Aligning formatting between Black and Ruff. * Updating with the small requested modifications. * Update toolkit/ThreeWToolkit/data_visualization/three_w_chart.py Co-authored-by: Rafael Padilla <31217453+rafaelpadilla@users.noreply.github.com> --------- Co-authored-by: Rafael Padilla <31217453+rafaelpadilla@users.noreply.github.com>
…eSeries_issue Refactoring DataVisualization to classes
* Updated md5 checksum to hardcoded sha256 digests, updated tests to prevent figshare rate limiting, and added requests as dependency * Linting * Fix dependency versioning * Reinject request headers for testing
Changing the ThreeWChart class to properly inherit from our plots base class
…and implement dynamic version retrieval in __init__.py
Update imports - Closes #15
…ts to use proper download links from figshare, instead of derived links.
Making tests resilient against figshare API being down;
…shing-pypi Bump version to 2.0.1 and fix packaging metadata for PyPI release
Co-authored-by: Rafael Padilla <31217453+rafaelpadilla@users.noreply.github.com>
Adapt Enum types properly.
Contributor
Author
|
Just a CI test |
rafaelpadilla
deleted the
rafaelpadilla/renaming_variables_with_meaningful_names
branch
rafaelpadilla
restored the
rafaelpadilla/renaming_variables_with_meaningful_names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request, I confirm that I have read and fully accept and agree with one of the Petrobras' Contributor License Agreements (CLAs):
Our CLAs are based on the Apache Software Foundation's CLAs: