Feature/db adapters #3

ondrej-nemec · 2019-04-11T10:56:37Z

Switch between sql dialects will be usefull
-> added interface which allow this and two basic implementation - mysql and mssql
especly I need used this tool with MsSql Server

petrknap · 2019-04-11T15:58:57Z

src/DbAdapters/DbAdapter.php

+
+     public function selectOneNull($tableName);
+
+     public function createTableIfNotExists($tableName);


It can be less general, f.e. createMigrationTable($tableName).

I'm not sure, if I do new instance of this adapter, I will need know what I have to do
This return string which create table ONLY IF table not exists. This is very important

petrknap · 2019-04-11T16:01:21Z

src/DbAdapters/DbAdapter.php

+
+     public function createTableIfNotExists($tableName);
+
+     public function insertIntoTable($tableName);


insertIntoMigrationTable

petrknap · 2019-04-11T16:02:07Z

src/DbAdapters/DbAdapter.php

+
+     public function insertIntoTable($tableName);
+
+     public function selectNullFromId($tableName);


selectByIdFromMigrationTable

petrknap · 2019-04-11T16:08:26Z

src/SqlMigrationTool.php

        $this->pdo->setAttribute(\PDO::ATTR_ERRMODE, \PDO::ERRMODE_EXCEPTION);
        $this->supportsMultiStatements = in_array($this->pdo->getAttribute(\PDO::ATTR_DRIVER_NAME), [
-            "mysql"
+           $this->adapter->getDbType()


This part checks if $this->pdo is capable to run multi statement. You can append another driver name to this array. Your change means that every adapter supports it.

Maybe I don't undenstand you last sence. If adapter returns string which is not in array that means that multi select are not supporter, isn't it?

petrknap · 2019-04-11T16:10:26Z

src/DbAdapters/DbAdapter.php

+
+namespace PetrKnap\Php\MigrationTool\DbAdapters;
+
+/*


Remove this placeholder comment

petrknap · 2019-04-11T18:23:35Z

I have an idea how to do this more systematic way. When do you need this change? I could do it this weekend.

ondrej-nemec · 2019-04-11T20:36:03Z

It will be satisfactory, Thank you very much. Btw. How idea you have?

petrknap · 2019-04-14T08:08:17Z

Try this https://github.com/petrknap/php-migrationtool/releases/tag/v3.0.0-alpha it uses DBAL and should works on every SQL database.

ondrej-nemec · 2019-04-15T15:30:20Z

Unfortunally, this version (3,0) has still problem on sql server
F.E.: SqlMigrationTool line 147 with {$this->migrationTableName} and TableExistsException is not catched becouse exception is DBAL exception
Sorry, my version works as I need

petrknap · 2019-04-17T16:47:08Z

It's covered by PetrKnap\Php\MigrationTool\Test\SqlMigrationToolTest::testCreateMigrationTableMethodWorks. What exception is it? Can you post it here?

petrknap · 2019-04-17T17:05:40Z

Try https://github.com/petrknap/php-migrationtool/releases/tag/v3.0.0-beta - it's quoted directly by DBAL now

ondrej-nemec · 2019-04-25T06:53:09Z

sorry for my delay,
today I tried your changes and first test was successful but second ended with exception
there is what my test project throws

PHP Fatal error:  Uncaught exception 'PDOException' with message 'SQLSTATE[42S01]: [Microsoft][SQL Server Native Client 11.0][SQL Server]There is already an object named 'migrations' in the database.' in C:\xam
pp\htdocs\projects\test\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOConnection.php:57
Stack trace:
#0 C:\xampp\htdocs\projects\test\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOConnection.php(57): PDO->exec('CREATE TABLE mi...')
#1 C:\xampp\htdocs\projects\test\vendor\doctrine\dbal\lib\Doctrine\DBAL\Connection.php(1012): Doctrine\DBAL\Driver\PDOConnection->exec('CREATE TABLE mi...')
#2 C:\xampp\htdocs\projects\test\vendor\doctrine\dbal\lib\Doctrine\DBAL\Schema\AbstractSchemaManager.php(1017): Doctrine\DBAL\Connection->executeUpdate('CREATE TABLE mi...')
#3 C:\xampp\htdocs\projects\test\vendor\doctrine\dbal\lib\Doctrine\DBAL\Schema\AbstractSchemaManager.php(443): Doctrine\DBAL\Schema\AbstractSchemaManager->_execSql(Array)
#4 C:\xampp\htdocs\projects\test\vendor\petrknap\php-migrationtool\src\SqlMigrationTool.php( in C:\xampp\htdocs\projects\test\vendor\petrknap\php-migrationtool\src\SqlMigrationTool.php on line 92

Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42S01]: [Microsoft][SQL Server Native Client 11.0][SQL Server]There is already an object named 'migrations' in the database.' in C:\xampp\ht
docs\projects\test\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOConnection.php:57
Stack trace:
#0 C:\xampp\htdocs\projects\test\vendor\doctrine\dbal\lib\Doctrine\DBAL\Driver\PDOConnection.php(57): PDO->exec('CREATE TABLE mi...')
#1 C:\xampp\htdocs\projects\test\vendor\doctrine\dbal\lib\Doctrine\DBAL\Connection.php(1012): Doctrine\DBAL\Driver\PDOConnection->exec('CREATE TABLE mi...')
#2 C:\xampp\htdocs\projects\test\vendor\doctrine\dbal\lib\Doctrine\DBAL\Schema\AbstractSchemaManager.php(1017): Doctrine\DBAL\Connection->executeUpdate('CREATE TABLE mi...')
#3 C:\xampp\htdocs\projects\test\vendor\doctrine\dbal\lib\Doctrine\DBAL\Schema\AbstractSchemaManager.php(443): Doctrine\DBAL\Schema\AbstractSchemaManager->_execSql(Array)
#4 C:\xampp\htdocs\projects\test\vendor\petrknap\php-migrationtool\src\SqlMigrationTool.php( in C:\xampp\htdocs\projects\test\vendor\petrknap\php-migrationtool\src\SqlMigrationTool.php on line 92

In your source is try-catch block on create table and TableExistsException is ignored, but there is not thrown TableExistException - this is DbalException - and this is answer to your previous question

thanks for your time

petrknap · 2019-05-08T08:40:16Z

https://github.com/petrknap/php-migrationtool/releases/tag/v3.0.0-rc1

RawGit is shutting down, replace it with jsDelivr

Ondřej Němec added 7 commits April 11, 2019 11:52

test are compatible for windows os

080678f

added dbadapter interface

8f83229

added mysql implementation of dbadapter

9fba21a

used db adapter

e450c2f

added mssql implementation of dbadapter

7c3a228

sqlserver ->sqlserver adapter

81ecaa3

sqlserver adapter repaired queries

6d5774d

petrknap reviewed Apr 11, 2019

View reviewed changes

ondrej-nemec pushed a commit to ondrej-nemec/php-migrationtool that referenced this pull request Dec 7, 2020

Merge pull request petrknap#3 from jsdelivrbot/master

8808934

RawGit is shutting down, replace it with jsDelivr


		public function selectOneNull($tableName);

		public function createTableIfNotExists($tableName);


		public function createTableIfNotExists($tableName);

		public function insertIntoTable($tableName);


		public function insertIntoTable($tableName);

		public function selectNullFromId($tableName);


		namespace PetrKnap\Php\MigrationTool\DbAdapters;

		/*

Feature/db adapters #3

Are you sure you want to change the base?

Feature/db adapters #3

Uh oh!

Conversation

ondrej-nemec commented Apr 11, 2019

Uh oh!

petrknap Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

ondrej-nemec Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

petrknap Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

petrknap Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

petrknap Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

ondrej-nemec Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

petrknap Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

petrknap commented Apr 11, 2019

Uh oh!

ondrej-nemec commented Apr 11, 2019

Uh oh!

petrknap commented Apr 14, 2019

Uh oh!

ondrej-nemec commented Apr 15, 2019

Uh oh!

petrknap commented Apr 17, 2019

Uh oh!

petrknap commented Apr 17, 2019

Uh oh!

ondrej-nemec commented Apr 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrknap commented May 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ondrej-nemec commented Apr 25, 2019 •

edited

Loading