fix(r): correct shell quote escaping in lintr command#424
Open
sims1253 wants to merge 1 commit intopeteromallet:mainfrom
Open
fix(r): correct shell quote escaping in lintr command#424sims1253 wants to merge 1 commit intopeteromallet:mainfrom
sims1253 wants to merge 1 commit intopeteromallet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: The R language plugin's lintr command had broken shell quote escaping that prevented it from executing properly.
Root Cause:
The Fix:
Changes:
• Switched to double quotes for the Python string, allowing single quotes inside for the R string
• Removed unnecessary cat/paste/capture.output wrapper
• Simplified to rely on lintr's default stdout behavior
• Output remains GNU-style formatted lint messages (compatible with fmt: "gnu")