feat: verify S243 @GenesisAutomator bounty — NO, duplicate of S012 (#547)#359
Open
xliry wants to merge 4 commits intopeteromallet:mainfrom
Open
feat: verify S243 @GenesisAutomator bounty — NO, duplicate of S012 (#547)#359xliry wants to merge 4 commits intopeteromallet:mainfrom
xliry wants to merge 4 commits intopeteromallet:mainfrom
Conversation
… (#451) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…eld confirmed (#456) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… S012 (#547) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #204
Submission: #204 (comment)
Author: @GenesisAutomator
Problem (in our own words)
S243 claims that
Issue.detailinschema.pyis an untypeddict[str, Any]bag serving 13+ detector-specific schemas, defeating TypedDict's purpose and creating fragile implicit coupling between producers and consumers. This is the exact same finding as S012 (@taco-devs), which was already verified as YES_WITH_CAVEATS.Evidence
desloppify/engine/_state/schema.py:83—detail: dict[str, Any]confirmeddesloppify/engine/_state/schema.py:58-82— 14 distinct shapes documented in commentsbounty-verification-@taco-devs-4000848013.md:32— S012 verification explicitly notes "S243 (@GenesisAutomator) covers the same topic later"git grep 'detail\['at 6eb2065 — 10 non-test files accessdetail[; 63 non-test files reference"detail"stringFix
No fix needed — verdict is NO (duplicate of S012).
Verdict
dict[str, Any]defeating TypedDict is validFinal verdict: NO (duplicate of S012, which was already verified as YES_WITH_CAVEATS)
Scores
Summary
S243 identifies the same
Issue.detail: dict[str, Any]god field that S012 already reported and that was verified as YES_WITH_CAVEATS with scores 5/6/4/5. The S012 verification file explicitly lists S243 as a known duplicate. S243 adds no novel code references, no new angle, and no additional depth.Why Desloppify Missed This
dict[str, Any]fields in TypedDicts that are accessed with 10+ distinct key patternsVerdict Files
Generated with Lota