Add support for totals and improvements to table formatting#5
Open
grdnkln wants to merge 3 commits intopetermaloney:mainfrom
Open
Add support for totals and improvements to table formatting#5grdnkln wants to merge 3 commits intopetermaloney:mainfrom
grdnkln wants to merge 3 commits intopetermaloney:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements putting totals at the bottom of the tables and to the JSON output.
I also needed to widen the "filename" column for drive names like "drive-tpmstate0-backup" that exceeded the current width which would cause the output to become garbled. Since I was changing the column width, I made it so the column widths can be customized via a variable at the top of the script.
Lastly I added support for automatic human-readable size conversion so it will choose the most appropriate unit e.g. KiB, MiB, GiB, TiB etc., in the output. There is also an argument -u / --units in case you want all the sizes reported in a single unit. Adding "--units MiB" would return the script to it's original behaviour where it outputs all sizes in MiB.
#3