Open
Conversation
Owner
|
Hey @azarakovskiy, Thanks for the PR. In general I like the idea of being able to swap two windows, but I find the usage a bit complicated. I wonder if there's a more intuitive / simpler way to approach this. One way to validate it is to write documentation on how to use the feature, I think the current implementation requires quite some explanation for others to understand. I'll give it some thought, but feel free to come up with a simpler approach as well. Apart from that:
But I would park these until after a more intuitive approach is found :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A function that swaps two windows.
The issue i'm solving is the following:
Implementation: