fix: preserve Unicode characters in filenames for --filter matching#1624
Open
Vmadmax wants to merge 2 commits intopestphp:4.xfrom
Open
fix: preserve Unicode characters in filenames for --filter matching#1624Vmadmax wants to merge 2 commits intopestphp:4.xfrom
Vmadmax wants to merge 2 commits intopestphp:4.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
The
--filteroption didn't work with Unicode characters (ß, ä, ö, ü, etc.) in filenames.For example,
--filter=".*Straß.*"failed to findStraßenTest.phpbecause the regex inTestCaseFactory.phpstripped all Unicode characters from the filename (StraßenTestbecameStraenTest).Changed the regex to use
\p{L}\p{N}(Unicode letters and Numbers) with the/umodifier to preserve Unicode characters.Related:
--