Skip to content

Fix --parallel dropping options #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flap152 wants to merge 2 commits into
base: 4.x
Choose a base branch
from
+10 −6
Open

Fix --parallel dropping options #1620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc39806
Fixing HandleArguments popArgument method to not delete duplicate arg…
flap152 Jan 18, 2026
67d3e5d
Refactor Coverage plugin to use HandleArguments trait and simplify ar…
flap152 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Plugins/Concerns/HandleArguments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,20 @@ public function pushArgument(string $argument, array $arguments): array

/**
* Pops the given argument from the arguments.
* Pops the given argument from the arguments and returns a re-indexed array.
*
* @param array<int, string> $arguments
* @return array<int, string>
*/
public function popArgument(string $argument, array $arguments): array
{
$arguments = array_flip($arguments);
$key = array_search($argument, $arguments, true);

unset($arguments[$argument]);
if ($key !== false) {
unset($arguments[$key]);
}

return array_values($arguments);

return array_values(array_flip($arguments));
}
}
6 changes: 3 additions & 3 deletions src/Plugins/Coverage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
*/
final class Coverage implements AddsOutput, HandlesArguments
{
use Concerns\HandleArguments;

private const string COVERAGE_OPTION = 'coverage';

private const string MIN_OPTION = 'min';
Expand Down Expand Up @@ -70,11 +72,9 @@ public function handleArguments(array $originals): array
return false;
}))];

$originals = array_flip($originals);
foreach ($arguments as $argument) {
unset($originals[$argument]);
$originals = $this->popArgument($argument, $originals);
}
$originals = array_flip($originals);

$inputs = [];
$inputs[] = new InputOption(self::COVERAGE_OPTION, null, InputOption::VALUE_NONE);
Expand Down