Skip to content

fix: make review-definition checklist concrete with domain-neutral violation patterns#786

Merged
FL4TLiN3 merged 2 commits intomainfrom
fix/review-checklist-concrete
Mar 13, 2026
Merged

fix: make review-definition checklist concrete with domain-neutral violation patterns#786
FL4TLiN3 merged 2 commits intomainfrom
fix/review-checklist-concrete

Conversation

@FL4TLiN3
Copy link
Contributor

Summary

  • Reviewer was passing perstack.toml that contained file paths, "Deliverables" sections, internal API names, and implementation details because the checklist only said "contains only domain constraints" (too abstract)
  • Replace abstract check with 5 concrete, domain-neutral flag criteria:
    • Output locations or structure (artifact enumeration)
    • Internal APIs of specified tools (methods/hooks/functions)
    • Named alternatives to reject
    • Implementation approach (how vs what)
    • Code snippets, data schemas, step-by-step procedures

Test plan

  • Re-run create-expert and verify reviewer flags "Deliverables:" sections, file paths, and API names
  • Confirm domain-neutral framing doesn't bias toward coding-only checks

🤖 Generated with Claude Code

FL4TLiN3 and others added 2 commits March 13, 2026 22:37
…olation patterns

Reviewer was passing perstack.toml with file paths, Deliverables sections,
internal API names, and implementation details because the checklist was too
abstract ("contains only domain constraints"). Add specific flag criteria:

- Output locations/structure (where to place results, artifact enumeration)
- Internal APIs of specified tools (methods/hooks/functions — derivable)
- Named alternatives to reject (implicit from positive specification)
- Implementation approach (how vs what)
- Code snippets, data schemas, step-by-step procedures

All patterns are domain-neutral per Design Principle 3 (Domain Agnosticism).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@FL4TLiN3 FL4TLiN3 merged commit 88b58f9 into main Mar 13, 2026
11 checks passed
@FL4TLiN3 FL4TLiN3 deleted the fix/review-checklist-concrete branch March 13, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant