fix: handle resolveToolResults event in tree builder#746
Closed
fix: handle resolveToolResults event in tree builder#746
Conversation
Add a full-featured log viewer for `perstack log` with: - Delegation tree builder that merges resume runs into logical nodes - Job list, run list, event list, and checkpoint screens - Drill-down navigation with keyboard shortcuts - Bottom panel component for info display - flattenTreeAll utility for unpruned tree traversal - Comprehensive tests for tree building including failed delegates Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add @perstack/log dependency to tui-components - Add inputTokens, outputTokens, cachedInputTokens to DelegationTreeNode type - Fix implicit any types in app.tsx - Export log-viewer from package entry point to satisfy knip - Fix lint: prefix unused parameter with underscore Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add explicit handling for the resolveToolResults event type in buildRunTreeFromEvents. This event fires after MCP tool execution and after resumeFromStop when all tool results are resolved. Without this handler, these events were silently ignored in the switch statement. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FL4TLiN3
force-pushed
the
fix/resolve-tool-results-handling
branch
from
0a1ea70 to
fbac84b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveToolResultsevent type inbuildRunTreeFromEventsresumeFromStopwhen all tool results are resolvedTest plan
bun test packages/tui-components/src/log-viewer/build-run-tree.test.ts— 14 tests pass🤖 Generated with Claude Code