Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/persist-failed-delegation.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@perstack/runtime": patch
---

Persist startRun and stopRunByError events for failed delegations
56 changes: 53 additions & 3 deletions packages/runtime/src/orchestration/delegation-executor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,12 @@ import type {
ToolResult,
Usage,
} from "@perstack/core"
import { resolveModelTier, resolveModelTierWithFallback } from "@perstack/core"
import {
resolveModelTier,
resolveModelTierWithFallback,
startRun,
stopRunByError,
} from "@perstack/core"

/** Reference to the parent Expert that delegated */
type DelegatedBy = NonNullable<Checkpoint["delegatedBy"]>
Expand Down Expand Up @@ -247,12 +252,57 @@ export class DelegationExecutor {
{ ...parentOptions, returnOnDelegationComplete: true },
)
} catch (error) {
// Child run crashed (e.g., MCP connection failure) - return error to parent
// Child run crashed before state machine started (e.g., MCP connection failure).
// Emit startRun + stopRunByError events so the failure is persisted in the event store.
const errorMessage = error instanceof Error ? error.message : String(error)
const errorName = error instanceof Error ? error.name : "Error"

const startRunEvent = startRun(delegateSetting, delegateCheckpoint, {
initialCheckpoint: delegateCheckpoint,
inputMessages: [],
model: delegateSetting.model ?? "",
})

const errorCheckpoint: Checkpoint = {
...delegateCheckpoint,
status: "stoppedByError",
error: {
name: errorName,
message: errorMessage,
isRetryable: false,
},
}

const stopRunByErrorEvent = stopRunByError(delegateSetting, errorCheckpoint, {
checkpoint: errorCheckpoint,
step: {
stepNumber: 1,
newMessages: [],
usage: createEmptyUsage(),
startedAt: Date.now(),
},
error: {
name: errorName,
message: errorMessage,
isRetryable: false,
},
})

// Persist events via parent's callbacks
if (parentOptions?.storeEvent) {
await parentOptions.storeEvent(startRunEvent).catch(() => {})
await parentOptions.storeEvent(stopRunByErrorEvent).catch(() => {})
}
if (parentOptions?.eventListener) {
parentOptions.eventListener(startRunEvent)
parentOptions.eventListener(stopRunByErrorEvent)
}

return {
toolCallId,
toolName,
expertKey: expert.key,
text: `Delegation to ${expert.key} failed: ${error instanceof Error ? error.message : String(error)}`,
text: `Delegation to ${expert.key} failed: ${errorMessage}`,
stepNumber: parentContext.stepNumber,
deltaUsage: createEmptyUsage(),
}
Expand Down
Loading