Skip to content

chore: add parse failure logging to E2E event parser #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FL4TLiN3 merged 2 commits into from
Mar 4, 2026
Merged

chore: add parse failure logging to E2E event parser #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
802c110
chore: use stderr for E2E debug logging to ensure visibility in CI
FL4TLiN3 Mar 4, 2026
29e7643
chore: add parse failure logging to event parser
FL4TLiN3 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion e2e/lib/event-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,19 @@ function tryParseEvent(text: string, events: ParsedEvent[]): void {
if (data.type) {
events.push({ ...data, raw: text })
}
} catch {}
} catch (e) {
if (
text.includes('"startRun"') ||
text.includes('"completeRun"') ||
text.includes('"stopRun')
) {
process.stderr.write(
`[PARSE_FAIL] Failed to parse event (len=${text.length}): ${(e as Error).message}\n`,
)
process.stderr.write(`[PARSE_FAIL] first 200 chars: ${text.slice(0, 200)}\n`)
process.stderr.write(`[PARSE_FAIL] last 200 chars: ${text.slice(-200)}\n`)
}
}
}

export function filterEventsByType<T extends RunEvent["type"]>(
Expand Down
13 changes: 6 additions & 7 deletions e2e/perstack-cli/continue.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,12 @@ describe.concurrent("Continue Job", () => {
{ timeout: LLM_TIMEOUT },
)
const continueResult = withEventParsing(continueCmdResult)
if (!continueResult.events.find((e) => e.type === "completeRun")) {
console.log(`[DEBUG continue] exitCode: ${continueCmdResult.exitCode}`)
console.log(
`[DEBUG continue] events: ${JSON.stringify(continueResult.events.map((e) => e.type))}`,
)
console.log(`[DEBUG continue] stdout: ${continueCmdResult.stdout.slice(0, 2000)}`)
console.log(`[DEBUG continue] stderr: ${continueCmdResult.stderr.slice(0, 2000)}`)
process.stderr.write(
`\n[DEBUG continue] exitCode=${continueCmdResult.exitCode} events=${JSON.stringify(continueResult.events.map((e) => e.type))}\n`,
)
process.stderr.write(`[DEBUG continue] stdout:\n${continueCmdResult.stdout.slice(0, 3000)}\n`)
if (continueCmdResult.stderr) {
process.stderr.write(`[DEBUG continue] stderr:\n${continueCmdResult.stderr.slice(0, 1000)}\n`)
}
expect(assertEventSequenceContains(continueResult.events, ["resumeFromStop"]).passed).toBe(true)
expect(
Expand Down
13 changes: 6 additions & 7 deletions e2e/perstack-cli/providers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,12 @@ describe.concurrent("LLM Providers", () => {
provider,
})
const result = withEventParsing(cmdResult)
if (result.exitCode !== 0 || !result.events.find((e) => e.type === "completeRun")) {
console.log(`[DEBUG ${provider}] exitCode: ${result.exitCode}`)
console.log(
`[DEBUG ${provider}] events: ${JSON.stringify(result.events.map((e) => e.type))}`,
)
console.log(`[DEBUG ${provider}] stdout: ${result.stdout.slice(0, 2000)}`)
console.log(`[DEBUG ${provider}] stderr: ${result.stderr.slice(0, 2000)}`)
process.stderr.write(
`\n[DEBUG ${provider}] exitCode=${result.exitCode} events=${JSON.stringify(result.events.map((e) => e.type))}\n`,
)
process.stderr.write(`[DEBUG ${provider}] stdout:\n${result.stdout.slice(0, 3000)}\n`)
if (result.stderr) {
process.stderr.write(`[DEBUG ${provider}] stderr:\n${result.stderr.slice(0, 1000)}\n`)
}
expect(result.exitCode).toBe(0)
expect(assertEventSequenceContains(result.events, ["startRun", "completeRun"]).passed).toBe(
Expand Down