fix: short-circuit selection TUI when expert key is provided#657
Merged
fix: short-circuit selection TUI when expert key is provided#657
Conversation
In Bun-compiled binaries (Docker), the Ink render() for the selection phase caused the event loop to exit before React effects could fire, making `perstack start <expert> <query>` exit silently with code 0. Skip the Ink render entirely when initialExpertKey is already known, returning the selection result directly instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
perstack start <expert> <query>exiting silently with code 0 in Docker (Bun-compiled binary)render()for the selection phase caused the Bun event loop to exit before ReactuseEffectcould fireexit(), sowaitUntilExit()never resolvedinitialExpertKeyis already known, return the selection result directly without rendering InkTest plan
bun run typecheckpassesbun run testpasses (47 tui-components tests)bun run buildpassesbun run format-and-lintpassesdocker run --rm -t -e ANTHROPIC_API_KEY=... perstack start create-expert "query"now renders TUI and executes expert🤖 Generated with Claude Code