Fix: getExpertScope fails for versioned expert keys#614
Merged
Conversation
getExpertScope() returned the full key including @version/@tag suffix for coordinator experts, causing validateDelegation() to reject valid same-scope delegations when keys contain version suffixes (e.g., "weather-reporter@draftRefId" vs "@weather-reporter/data-fetcher@draftRefId"). Also fix getExpertShortName() to strip version suffixes from both coordinator and delegate keys, and update validateDelegation() to use getExpertScope() for the delegate-to-own-coordinator check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getExpertScope()returned the full key including@version/@tagsuffix for coordinator experts, causingvalidateDelegation()to reject valid same-scope delegationsZodError: Expert "weather-reporter@draftRefId" cannot delegate to out-of-scope delegate "@weather-reporter/data-fetcher@draftRefId"getExpertScope()to strip@version/@tagsuffix from coordinator keysgetExpertShortName()to strip version suffixes from both coordinator and delegate keysvalidateDelegation()delegate-to-own-coordinator check to usegetExpertScope()instead of direct string comparisonTest plan
getExpertScopewith versioned/tagged coordinator and delegate keysgetExpertShortNamewith versioned keysvalidateDelegationwith versioned keys (valid and invalid cases)expertSchema.parse()tests for versioned and tagged key delegationbun test, typecheck, biome check all pass🤖 Generated with Claude Code