Skip to content

fix: use startRun in single-type filter E2E test to avoid LLM flakiness #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FL4TLiN3 merged 1 commit into from
Feb 23, 2026
Merged

fix: use startRun in single-type filter E2E test to avoid LLM flakiness #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 18 additions & 23 deletions e2e/perstack-cli/options.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,35 +162,30 @@ describe.concurrent("CLI Options", () => {

describe.concurrent("CLI Options - Filter", () => {
/** Verifies --filter option with single type.
* Retries up to 3 times because --filter completeRun only outputs the final
* event; when the LLM call errors the runtime emits stopRunByError (blocked
* by the filter) and exits 0 with zero events.
* Uses startRun (emitted before LLM calls) to avoid flakiness from LLM
* errors that produce stopRunByError instead of completeRun.
*/
it(
"should filter events to only completeRun",
"should filter events to only startRun",
async () => {
const args = [
"run",
"--config",
GLOBAL_RUNTIME_CONFIG,
"--filter",
"completeRun",
"e2e-global-runtime",
"Say hello",
]
let result = withEventParsing(await runCli(args, { timeout: LLM_TIMEOUT }))
for (
let attempt = 1;
attempt < 3 && result.exitCode === 0 && result.events.length === 0;
attempt++
) {
result = withEventParsing(await runCli(args, { timeout: LLM_TIMEOUT }))
}
const cmdResult = await runCli(
[
"run",
"--config",
GLOBAL_RUNTIME_CONFIG,
"--filter",
"startRun",
"e2e-global-runtime",
"Say hello",
],
{ timeout: LLM_TIMEOUT },
)
const result = withEventParsing(cmdResult)
expect(result.exitCode).toBe(0)

// All events should be completeRun
// All events should be startRun
const eventTypes = result.events.map((e) => e.type)
expect(eventTypes.every((t) => t === "completeRun")).toBe(true)
expect(eventTypes.every((t) => t === "startRun")).toBe(true)
expect(eventTypes.length).toBeGreaterThan(0)
},
LLM_TIMEOUT,
Expand Down