fix: use fallback text instead of retry for empty GeneratingRunResult#574
Merged
fix: use fallback text instead of retry for empty GeneratingRunResult#574
Conversation
Replace the retry approach with a simple fallback. When the LLM generates no visible text in GeneratingRunResult (e.g., only reasoning/thinking with extended thinking), fall back to "OK" since the task is already complete (attemptCompletion succeeded). This avoids expensive extra LLM calls and retry events that break assertNoRetry in E2E delegation chain tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeneratingRunResult"OK"since the task is already complete (attemptCompletionsucceeded, no remaining todos)retryevents that breakassertNoRetryin E2E delegation chain testsTest plan
falls back to 'OK' when LLM generates empty text🤖 Generated with Claude Code