fix: preserve .js output extension with tsdown 0.20#571
Merged
Conversation
tsdown 0.20 defaults fixedExtension to true for node platform, which outputs .mjs instead of .js. This breaks E2E tests and publishConfig bin paths that reference dist/bin/cli.js. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FL4TLiN3
force-pushed
the
fix/tsdown-fixed-extension
branch
from
809cc16 to
3f36726
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixedExtensiondefault totrueforplatform: "node", causing output files to use.mjsinstead of.jse2e/lib/runner.ts) andpublishConfig.binpaths that referencedist/bin/cli.jsfixedExtension: falsein the shared base tsdown config so extensions followpackage.json"type": "module"conventionTest plan
pnpm build --force— all 23 packages build, CLI outputsdist/bin/cli.jspnpm typecheck— passespnpm test— 1098 tests pass🤖 Generated with Claude Code