Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fix-false-retry-activity.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@perstack/core": patch
---

fix: stop producing false RetryActivity for proceeding/init checkpoints

When `getActivities()` encounters checkpoints with `proceeding` or `init` status and no tool calls, it now returns empty activities instead of creating a misleading RetryActivity with "No tool call or result found". These are normal intermediate states during parallel delegate execution.
88 changes: 87 additions & 1 deletion packages/core/src/utils/activity.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,95 @@ describe("getActivities", () => {
})
})

describe("intermediate status with no tool calls", () => {
it("returns empty activities for proceeding status with no tool calls", () => {
const checkpoint = createBaseCheckpoint({ status: "proceeding", stepNumber: 2 })
const step = createBaseStep({ stepNumber: 2, toolCalls: [], toolResults: [] })

const activities = getActivities({ checkpoint, step })

expect(activities).toEqual([])
})

it("returns only query activity for proceeding status at step 1", () => {
const checkpoint = createBaseCheckpoint({ status: "proceeding", stepNumber: 1 })
const step = createBaseStep({
stepNumber: 1,
toolCalls: [],
toolResults: [],
inputMessages: [
{
id: "m-1",
type: "userMessage",
contents: [{ type: "textPart", id: "tp-1", text: "Hello" }],
},
],
})

const activities = getActivities({ checkpoint, step })

expect(activities).toHaveLength(1)
expect(activities[0].type).toBe("query")
})

it("returns empty activities for init status with no tool calls", () => {
const checkpoint = createBaseCheckpoint({ status: "init", stepNumber: 2 })
const step = createBaseStep({ stepNumber: 2, toolCalls: [], toolResults: [] })

const activities = getActivities({ checkpoint, step })

expect(activities).toEqual([])
})

it("returns empty activities for proceeding status when tool calls have no matching results", () => {
const checkpoint = createBaseCheckpoint({ status: "proceeding", stepNumber: 2 })
const step = createBaseStep({
stepNumber: 2,
toolCalls: [
createToolCall({
id: "tc-1",
toolName: "exec",
args: { command: "ls" },
}),
],
toolResults: [],
})

const activities = getActivities({ checkpoint, step })

expect(activities).toEqual([])
})

it("still returns RetryActivity for stoppedByExceededMaxSteps with no tool calls", () => {
const checkpoint = createBaseCheckpoint({
status: "stoppedByExceededMaxSteps",
stepNumber: 2,
})
const step = createBaseStep({ stepNumber: 2, toolCalls: [], toolResults: [] })

const activities = getActivities({ checkpoint, step })

expect(activities).toHaveLength(1)
expect(activities[0].type).toBe("retry")
})

it("still returns RetryActivity for stoppedByCancellation with no tool calls", () => {
const checkpoint = createBaseCheckpoint({
status: "stoppedByCancellation",
stepNumber: 2,
})
const step = createBaseStep({ stepNumber: 2, toolCalls: [], toolResults: [] })

const activities = getActivities({ checkpoint, step })

expect(activities).toHaveLength(1)
expect(activities[0].type).toBe("retry")
})
})

describe("retry activity", () => {
it("returns retry activity when no tool call or result", () => {
const checkpoint = createBaseCheckpoint()
const checkpoint = createBaseCheckpoint({ status: "stoppedByExceededMaxSteps" })
const step = createBaseStep({
newMessages: [
{
Expand Down
6 changes: 6 additions & 0 deletions packages/core/src/utils/activity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ export function getActivities(params: GetActivitiesParams): ActivityOrGroup[] {
if (status === "completed") {
return prependQuery([createCompleteActivity(step.newMessages, reasoning)])
}
if (status === "proceeding" || status === "init") {
return prependQuery([])
}
return prependQuery([createRetryActivity(step.newMessages, reasoning)])
}

Expand All @@ -166,6 +169,9 @@ export function getActivities(params: GetActivitiesParams): ActivityOrGroup[] {
if (status === "completed") {
return prependQuery([createCompleteActivity(step.newMessages, reasoning)])
}
if (status === "proceeding" || status === "init") {
return prependQuery([])
}
return prependQuery([createRetryActivity(step.newMessages, reasoning)])
}

Expand Down