refactor: move query input from selection to execution phase#543
Merged
refactor: move query input from selection to execution phase#543
Conversation
- Remove query from SelectionResult/SelectionParams; selection now returns only expertKey + checkpoint - Add "waiting" RunStatus to execution; InterfacePanel collects first query when no query provided - Add queryReady promise to renderExecution; start-handler awaits it before calling perstackRun - Render log events (initializeRuntime, skillConnected) with ActionRow bullet format - Clean up terminal buffer on phase transitions by rendering null before exit - Remove tree indicator from ActionRow, add gap between log events Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FL4TLiN3
force-pushed
the
refactor/move-query-input-to-execution
branch
from
93bb437 to
bb9a7d6
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expertKey+checkpoint"waiting"RunStatus to execution;InterfacePanelcollects the first query when no CLI query is providedqueryReadypromise torenderExecution;start-handlerawaits it before callingperstackRuninitializeRuntime,skillConnected,skillDisconnected) with● ActionRowbullet format instead of plain dimmed textnullbeforeexit()(deferred exit pattern)└tree indicator fromActionRow, addmarginBottomgap between log eventsTest plan
pnpm typecheck— 22/22 passedpnpm test— 92 files, 1030 tests passedpnpm build— 22/22 passedpnpm format-and-lint— no new warningsperstack start→ select expert → InterfacePanel appears → type query → Enter → execution beginsperstack start expert-key "query"→ execution starts immediately (no waiting state)🤖 Generated with Claude Code