Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/remove-redundant-tools.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@perstack/base": patch
"@perstack/core": patch
"@perstack/tui-components": patch
"@perstack/runtime": patch
---

Remove 8 redundant base tools (healthCheck, appendTextFile, createDirectory, deleteDirectory, deleteFile, getFileInfo, listDirectory, moveFile) and slim down remaining tool descriptions
10 changes: 0 additions & 10 deletions apps/base/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,22 +39,12 @@ registerWriteTextFile(server)
### File Operations
- `readTextFile` - Read text files with optional line range
- `writeTextFile` - Create or overwrite text files
- `appendTextFile` - Append content to existing files
- `editTextFile` - Replace text in existing files
- `deleteFile` - Remove files
- `moveFile` - Move or rename files
- `getFileInfo` - Get file metadata
- `readImageFile` - Read image files (PNG, JPEG, GIF, WebP)
- `readPdfFile` - Read PDF files

### Directory Operations
- `listDirectory` - List directory contents
- `createDirectory` - Create directories
- `deleteDirectory` - Remove directories

### Utilities
- `exec` - Execute system commands
- `healthCheck` - Check Perstack runtime health status
- `todo` - Task list management
- `clearTodo` - Clear task list
- `attemptCompletion` - Signal task completion (validates todos first)
Expand Down
1 change: 0 additions & 1 deletion apps/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"@perstack/core": "workspace:*",
"commander": "^14.0.3",
"mime-types": "^3.0.2",
"ts-dedent": "^2.2.0",
"zod": "^4.3.6"
},
"devDependencies": {
Expand Down
7 changes: 0 additions & 7 deletions apps/base/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,9 @@ export {
createBaseServer,
registerAllTools,
} from "./server.js"
export * from "./tools/append-text-file.js"
export * from "./tools/attempt-completion.js"
export * from "./tools/create-directory.js"
export * from "./tools/delete-directory.js"
export * from "./tools/delete-file.js"
export * from "./tools/edit-text-file.js"
export * from "./tools/exec.js"
export * from "./tools/get-file-info.js"
export * from "./tools/list-directory.js"
export * from "./tools/move-file.js"
export * from "./tools/read-image-file.js"
export * from "./tools/read-pdf-file.js"
export * from "./tools/read-text-file.js"
Expand Down
30 changes: 1 addition & 29 deletions apps/base/src/lib/safe-file.test.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
import fs from "node:fs/promises"
import { afterEach, describe, expect, it } from "vitest"
import {
isSymlinkProtectionFullySupported,
safeAppendFile,
safeReadFile,
safeWriteFile,
} from "./safe-file.js"
import { isSymlinkProtectionFullySupported, safeReadFile, safeWriteFile } from "./safe-file.js"

const testFile = "safe-file.test.txt"
const testSymlink = "safe-file.test.link"
Expand Down Expand Up @@ -67,29 +62,6 @@ describe("safe-file", () => {
})
})

describe("safeAppendFile", () => {
it("appends content to file", async () => {
await fs.writeFile(testFile, "hello")
await safeAppendFile(testFile, " world")
const content = await fs.readFile(testFile, "utf-8")
expect(content).toBe("hello world")
})

it("rejects symbolic links", async () => {
await fs.writeFile(testFile, "content")
try {
await fs.symlink(testFile, testSymlink)
await expect(safeAppendFile(testSymlink, "malicious")).rejects.toThrow("symbolic link")
} catch (error) {
const err = error as { code?: string }
if (err.code === "EPERM" || err.code === "ENOTSUP") {
return
}
throw error
}
})
})

describe("isSymlinkProtectionFullySupported", () => {
it("returns boolean indicating O_NOFOLLOW support", () => {
const result = isSymlinkProtectionFullySupported()
Expand Down
12 changes: 0 additions & 12 deletions apps/base/src/lib/safe-file.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,3 @@ export async function safeReadFile(path: string): Promise<string> {
await handle?.close()
}
}

export async function safeAppendFile(path: string, data: string): Promise<void> {
let handle: FileHandle | undefined
try {
await checkNotSymlink(path)
const flags = constants.O_WRONLY | constants.O_APPEND | O_NOFOLLOW
handle = await open(path, flags)
await handle.writeFile(data, "utf-8")
} finally {
await handle?.close()
}
}
16 changes: 0 additions & 16 deletions apps/base/src/server.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,8 @@
import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js"
import packageJson from "../package.json" with { type: "json" }
import { registerAppendTextFile } from "./tools/append-text-file.js"
import { registerAttemptCompletion } from "./tools/attempt-completion.js"
import { registerCreateDirectory } from "./tools/create-directory.js"
import { registerDeleteDirectory } from "./tools/delete-directory.js"
import { registerDeleteFile } from "./tools/delete-file.js"
import { registerEditTextFile } from "./tools/edit-text-file.js"
import { registerExec } from "./tools/exec.js"
import { registerGetFileInfo } from "./tools/get-file-info.js"
import { registerHealthCheck } from "./tools/health-check.js"
import { registerListDirectory } from "./tools/list-directory.js"
import { registerMoveFile } from "./tools/move-file.js"
import { registerReadImageFile } from "./tools/read-image-file.js"
import { registerReadPdfFile } from "./tools/read-pdf-file.js"
import { registerReadTextFile } from "./tools/read-text-file.js"
Expand All @@ -32,19 +24,11 @@ export function registerAllTools(server: McpServer): void {
registerTodo(server)
registerClearTodo(server)
registerExec(server)
registerGetFileInfo(server)
registerHealthCheck(server)
registerReadTextFile(server)
registerReadImageFile(server)
registerReadPdfFile(server)
registerWriteTextFile(server)
registerAppendTextFile(server)
registerEditTextFile(server)
registerMoveFile(server)
registerDeleteFile(server)
registerListDirectory(server)
registerCreateDirectory(server)
registerDeleteDirectory(server)
}

/**
Expand Down
62 changes: 0 additions & 62 deletions apps/base/src/tools/append-text-file.test.ts

This file was deleted.

61 changes: 0 additions & 61 deletions apps/base/src/tools/append-text-file.ts

This file was deleted.

17 changes: 1 addition & 16 deletions apps/base/src/tools/attempt-completion.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js"
import { dedent } from "ts-dedent"
import { errorToolResult, successToolResult } from "../lib/tool-result.js"
import { getRemainingTodos } from "./todo.js"

Expand All @@ -20,21 +19,7 @@ export function registerAttemptCompletion(server: McpServer) {
"attemptCompletion",
{
title: "Attempt completion",
description: dedent`
Task completion signal with automatic todo validation.
Use cases:
- Signaling task completion to Perstack runtime
- Validating all todos are complete before ending
- Ending the current expert's work cycle
How it works:
- Checks the current todo list for incomplete items
- If incomplete todos exist: returns them and continues the agent loop
- If no incomplete todos: returns empty object and ends the agent loop
Notes:
- Mark all todos as complete before calling
- Use clearTodo if you want to reset and start fresh
- Prevents premature completion by surfacing forgotten tasks
`,
description: "Signal task completion. Validates all todos are complete before ending.",
inputSchema: {},
},
async () => {
Expand Down
36 changes: 0 additions & 36 deletions apps/base/src/tools/create-directory.test.ts

This file was deleted.

Loading