fix: Prevent undefined result in reasoning budget assertions#523
Merged
fix: Prevent undefined result in reasoning budget assertions#523
Conversation
`x.thinking && x.thinking.length > 0` returns `undefined` (not `false`) when `thinking` is undefined, causing `expect(undefined).toBe(true)` to fail. Use optional chaining with nullish coalescing instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x.thinking && x.thinking.length > 0returningundefinedinstead offalsewhenthinkingis undefined(x.thinking?.length ?? 0) > 0to always return a booleanContext
CI run #22034924147 failed because
expect(undefined).toBe(true)in OpenAI "should produce more reasoning tokens with higher budget".🤖 Generated with Claude Code