refactor: clean up knip config by removing phantom dependencies#520
Merged
refactor: clean up knip config by removing phantom dependencies#520
Conversation
Remove dotenv, ink, react from CLI apps' dependencies — these were never imported in app source code but listed solely for tsup auto-externalization. Since tsup bundles workspace packages and resolves their transitive deps, these are bundled through @perstack/tui and @perstack/tui-components without needing to appear in the apps' package.json. - Remove dotenv, ink, react from apps/perstack and apps/create-expert deps - Add external: ["react-devtools-core"] to CLI tsup configs (ink optional dep) - Delete dead barrel file packages/tui-components/src/utils/index.ts - Remove tui-components ignore workaround from knip config - Reduce ignoreDependencies from 9 entries to 2 (vitest + @perstack/runtime) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotenv,ink,reactfromdependenciesinapps/perstackandapps/create-expert. These were never directly imported in app source code — they are transitively resolved and bundled by tsup through@perstack/tuiand@perstack/tui-componentsexternal: ["react-devtools-core"]to CLI tsup configs (optional ink dev dependency that cannot be bundled)packages/tui-components/src/utils/index.ts(EventQueueis imported directly fromevent-queue.js)ignoreDependenciesfrom 9 entries to 2 (vitest+@perstack/runtime)Changes
apps/perstack/package.jsonapps/create-expert/package.jsonapps/*/tsup.config.tsexternal: ["react-devtools-core"]packages/tui-components/src/utils/index.tsknip.jsonTest plan
pnpm build— all 22 tasks passpnpm typecheck— all 22 tasks passpnpm test— 100 test files, 1093 tests passpnpm check-deps(knip) — clean, no violations🤖 Generated with Claude Code