Conversation
FL4TLiN3
changed the title
… lockfile operations Consolidate perstack.toml parsing, config resolution, and lockfile management into a single dedicated package, eliminating code duplication across tui, installer, and create-expert. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… layer Config resolution (getPerstackConfig, findLockfile, loadLockfile) is an application concern, not a library concern. Move it to .action() handlers in apps/perstack and apps/create-expert so that --help works without a valid perstack.toml and library packages receive pre-resolved config. - Make perstackConfig required in resolveRunContext, startHandler, runHandler - Add RunHandlerOptions with perstackConfig and lockfile - Make installHandler receive configPath and perstackConfig as parameters - Remove @perstack/perstack-toml and memfs dependencies from @perstack/tui - Update context tests to pass PerstackConfig directly instead of TOML files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FL4TLiN3
force-pushed
the
refactor/extract-perstack-toml-package
branch
from
bba9e02 to
a5d96d3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@perstack/perstack-tomlpackage for TOML config and lockfile operationsgetPerstackConfig,findLockfile,loadLockfilecalls from library packages (@perstack/tui,@perstack/installer) to.action()handlers inapps/perstackandapps/create-expertperstackConfigrequired inresolveRunContext,startHandler,runHandler,installHandler— libraries receive pre-resolved configcreate-expertmodule-level config loading that could break--helpwhenperstack.tomlis missing@perstack/perstack-tomlandmemfsdependencies from@perstack/tuiMotivation
Config resolution (file lookup, TOML parsing) is an application-level concern. Having it inside library packages (
@perstack/tui,@perstack/installer) caused:smol-tomldependency scattered across 3 packagescreate-expert --helpfailing whenperstack.tomlis absent (module-level parse)Test plan
pnpm typecheck— 22/22 passpnpm test— 100 files, 1093 tests passpnpm build— 22/22 passpnpm format-and-lint— clean (pre-existing warnings only)pnpm run validate:changeset— pass🤖 Generated with Claude Code