fix: externalize CJS deps (ink, react, dotenv) from ESM bundles#493
Merged
fix: externalize CJS deps (ink, react, dotenv) from ESM bundles#493
Conversation
Move ink, react, dotenv, and @perstack/runtime to dependencies in both
perstack and create-expert so tsup externalizes them instead of bundling.
This eliminates CJS require("path") errors from signal-exit, stack-utils,
and dotenv when running the published ESM bundles.
Bundle sizes: create-expert 4MB→145KB, perstack similarly reduced.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ink,react,dotenvby adding them todependenciesin bothperstackandcreate-expert@perstack/runtimeincreate-expert(already done inperstack)react-devtools-corefrom tsupexternal(no longer needed — ink is externalized)Root cause
tsup bundles devDependencies into ESM output. CJS modules (
signal-exit@3.0.7,stack-utils@2.0.6,dotenv@17.2.3) userequire("path")etc., which fails in ESM bundles because tsup's CJS shim can't resolve Node.js builtins.Result
__require()calls in both bundles🤖 Generated with Claude Code