fix(runtime): add stoppedByCancellation status for proper cancellation handling#457
Merged
fix(runtime): add stoppedByCancellation status for proper cancellation handling#457
Conversation
…n handling When shouldContinueRun returns false, the coordinator now sets the checkpoint status to stoppedByCancellation. This allows the run loop to properly handle the cancellation case and update the job status accordingly. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change RuntimeVersion from literal "v1.0" to pattern `v${number}.${number}`
- Split runtime-version E2E tests to use separate config for future version tests
- This allows testing version validation failures without breaking other tests
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stoppedByCancellationstatus toCheckpointStatusandJobStatustypescoordinator.tsto setstatus: "stoppedByCancellation"whenshouldContinueRunreturnsfalsecase "stoppedByCancellation"inrun.tsto handle the cancellation terminal statestoppedByCancellationstatusProblem
When
shouldContinueRunreturnsfalse(cancellation),coordinator.tswas returning the checkpoint without changing its status (initorproceeding). Therun.tsswitch statement didn't handle these statuses, falling to the default case and throwing "Run stopped by unknown reason" error.Solution
Added
stoppedByCancellationstatus to properly handle cancellation. This status is resumable via the default case ininit.ts(same as other resumable statuses likecompleted,proceeding).Test plan
stoppedByCancellationterminal state handling inrun.test.tsstoppedByCancellationstatus being set incoordinator.test.tsstoppedByCancellationininit.test.ts🤖 Generated with Claude Code