fix: allow empty string for Expert description field#438
Merged
Conversation
The expertSchema description field had `.min(1)` validation which rejected empty strings but accepted undefined. This caused issues with UI forms that typically send empty fields as "". Changes: - Remove `.min(1)` from description field in expertSchema - Add test case for empty string description Closes #437 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.min(1)validation fromexpertSchemadescription field to allow empty stringsContext
The
descriptionfield inexpertSchemahad.min(1)validation which rejected empty strings ("") but acceptedundefined. This caused issues with UI forms that typically send empty fields as empty strings rather than omitting them.Before:
z.string().min(1).max(1024 * 2).optional()undefined- valid"hello"- valid""- ZodErrorAfter:
z.string().max(1024 * 2).optional()undefined- valid"hello"- valid""- validThis aligns with how
descriptionfields are handled in skill schemas (McpStdioSkill,McpSseSkill,InteractiveSkill), which use.optional()without.min(1).Closes #437
Test plan
pnpm typecheck- passespnpm format-and-lint- passespnpm test- all unit tests passpnpm build- succeeds🤖 Generated with Claude Code