fix(tui): fix event accumulation across multiple runs in start command#431
Merged
fix(tui): fix event accumulation across multiple runs in start command#431
Conversation
FL4TLiN3
force-pushed
the
fix/event-accumulation
branch
from
086a18d to
07055df
Compare
When using `perstack start` with interactive tools, events from all runs in a job were not being loaded because `getAllEventContentsForJob` relied on `run-setting.json` files which are not always present. Added `getRunIdsByJobId` function that scans the runs directory directly, ensuring all runs are discovered even when `run-setting.json` is missing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
FL4TLiN3
force-pushed
the
fix/event-accumulation
branch
from
07055df to
7be9839
Compare
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
perstack startcommandgetRunIdsByJobIdfunction in@perstack/filesystem-storagethat scans runs directory directlygetAllEventContentsForJobto use directory scanning instead ofrun-setting.jsonProblem
When using
perstack startwith interactive tools, the TUI would display incorrectly because:getAllEventContentsForJobrelied ongetRunsByJobIdto find runsgetRunsByJobIdonly returned runs that hadrun-setting.jsonfilesrun-setting.jsonfiles were not being createdSolution
Added a new function
getRunIdsByJobIdthat directly scans theruns/directory to find all runIds, regardless of whetherrun-setting.jsonexists. This ensures all events are accumulated correctly.Test plan
🤖 Generated with Claude Code