Conversation
…r-base This change makes @perstack/core client-safe by removing the child_process dependency. The BaseAdapter class and ExecResult type are now exported from a new package @perstack/adapter-base. Changes: - Create new package packages/runtimes/adapter-base - Move BaseAdapter and ExecResult from @perstack/core - Update all runtime packages to depend on @perstack/adapter-base - Update imports in docker, claude-code, cursor, gemini adapters and apps/runtime This resolves issues where importing @perstack/core in Next.js client bundles would fail due to child_process not being available in browser environments. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@perstack/coreからBaseAdapterクラスを分離し、新パッケージ@perstack/adapter-baseに移動@perstack/coreがクライアントセーフになった（child_process依存を除去）@perstack/coreを安全にインポート可能Background
@perstack/coreに含まれていたBaseAdapterはchild_processをインポートしており、Next.js のクライアントバンドルで問題が発生していた：Changes
packages/runtimes/adapter-base/を作成BaseAdapterとExecResultを新パッケージに移動packages/runtimes/dockerpackages/runtimes/claude-codepackages/runtimes/cursorpackages/runtimes/geminiapps/runtimeTest plan
pnpm typecheck- 成功pnpm format-and-lint- 成功pnpm test- 成功pnpm build- 成功🤖 Generated with Claude Code