Skip to content

refactor(create-expert): consolidate duplicate property definitions with sync notes #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FL4TLiN3 merged 2 commits into from
Jan 3, 2026
Merged

refactor(create-expert): consolidate duplicate property definitions with sync notes #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc0b09e
refactor(create-expert): consolidate duplicate property definitions w…
FL4TLiN3 Jan 3, 2026
1fa212e
chore: add changeset for #385
FL4TLiN3 Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/refactor-385-consolidate-duplicates.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"create-expert": patch
---

Consolidate duplicate property definitions with sync notes

3 changes: 3 additions & 0 deletions apps/create-expert/src/lib/agents-md-template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ See docs/making-experts/best-practices.md for public guidelines.
- Uses \`attemptCompletion\`: Signals completion properly
- Error handling: Graceful with helpful messages

Note: These properties are also defined in create-expert-toml.ts.
Keep both files synchronized when updating.
Copy link

@cursor cursor bot Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal sync notes leak into generated output

The synchronization notes are placed inside template strings rather than as code comments. In agents-md-template.ts, the note referencing create-expert-toml.ts will appear in every generated AGENTS.md file that users see. In create-expert-toml.ts, the note referencing agents-md-template.ts becomes part of the PROPERTY_EXTRACTOR_INSTRUCTION sent to the LLM. These internal developer notes reference source files that end users and LLMs don't have access to, creating confusing output.

Additional Locations (1)

Fix in Cursor Fix in Web


## CLI Reference

### Running Experts
Expand Down
2 changes: 2 additions & 0 deletions apps/create-expert/src/lib/create-expert-toml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ Return a structured list of properties:
These properties ensure experts follow Perstack best practices.
See docs/making-experts/best-practices.md for the public guidelines.

Note: Also defined in agents-md-template.ts - keep synchronized.

**Security:**
- Minimal tool access: Uses \`pick\` for only needed tools
- Minimal environment: Uses \`requiredEnv\` for only needed variables
Expand Down