Skip to content

refactor(create-expert): remove untestable time-based criteria#394

Merged
FL4TLiN3 merged 1 commit intomainfrom
refactor/384-remove-time-criteria
Jan 3, 2026
Merged

refactor(create-expert): remove untestable time-based criteria#394
FL4TLiN3 merged 1 commit intomainfrom
refactor/384-remove-time-criteria

Conversation

@FL4TLiN3
Copy link
Contributor

@FL4TLiN3 FL4TLiN3 commented Jan 3, 2026

Summary

Removes time-based criteria that cannot be verified in automated testing.

Removed Criteria

Location Removed
Setup template "Target: Complete setup in under 2 minutes"
Design principles "Setup expert should complete in < 2 minutes"
Usability properties "Setup completes in under 2 minutes"
Usability properties "New users succeed within 5 minutes"

Replacement Criteria

Before After
"Setup efficiency: Setup completes in under 2 minutes" "Setup is straightforward: Setup detects missing config and guides user"
"Fresh user success: New users succeed within 5 minutes" "First-run clarity: Instructions are clear enough for copy-paste execution"

Why Time-Based Criteria Are Problematic

  1. Environment variability - Clock time varies by system
  2. Cannot simulate users - No way to define "new user" behavior
  3. Not automatable - Can't measure human time in automated tests

Closes #384

Test plan

  • CI passes
  • No behavior changes expected

Note

Documents a patch release for create-expert that removes untestable time-based criteria.

  • Adds .changeset/refactor-384-remove-time-criteria.md declaring a patch for create-expert and stating the removal

Written by Cursor Bugbot for commit 29acbaf. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@FL4TLiN3 FL4TLiN3 force-pushed the refactor/384-remove-time-criteria branch from 24a2035 to 29acbaf Compare January 3, 2026 07:53
@FL4TLiN3 FL4TLiN3 merged commit 879bd01 into main Jan 3, 2026
7 checks passed
@FL4TLiN3 FL4TLiN3 deleted the refactor/384-remove-time-criteria branch January 3, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: remove time-based criteria from usability-manager that cannot be tested

1 participant