Skip to content

fix(create-expert): add pick to internal experts for minimal privilege #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FL4TLiN3 merged 1 commit into from
Jan 3, 2026
Merged

fix(create-expert): add pick to internal experts for minimal privilege #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changeset/add-pick-to-experts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
"create-expert": patch
---

Add `pick` to all internal PBT framework experts for minimal privilege

Each expert now only has access to the tools it actually needs:
- `create-expert`: `["attemptCompletion"]`
- `property-extractor`: `["attemptCompletion"]`
- `ecosystem-builder`: `["readTextFile", "appendTextFile", "attemptCompletion"]`
- `integration-manager`: `["attemptCompletion"]`
- `functional-manager`: `["attemptCompletion"]`
- `usability-manager`: `["attemptCompletion"]`
- `expert-tester`: `["exec", "attemptCompletion"]`
- `report-generator`: `["attemptCompletion"]`
8 changes: 8 additions & 0 deletions apps/create-expert/src/lib/create-expert-toml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,7 @@ delegates = ["property-extractor", "ecosystem-builder", "integration-manager", "
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"
pick = ["attemptCompletion"]

# ----------------------------------------------------------------------------

Expand All @@ -634,6 +635,7 @@ ${PROPERTY_EXTRACTOR_INSTRUCTION}
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"
pick = ["attemptCompletion"]

# ----------------------------------------------------------------------------

Expand All @@ -648,6 +650,7 @@ ${ECOSYSTEM_BUILDER_INSTRUCTION}
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"
pick = ["readTextFile", "appendTextFile", "attemptCompletion"]
Copy link

@cursor cursor bot Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ecosystem-builder pick list mismatches its instruction

The ecosystem-builder instruction explicitly states "Use editTextFile to APPEND the Expert ecosystem" and "Do NOT use writeTextFile", but the pick list provides appendTextFile instead of editTextFile. The expert won't have access to the tool its own instructions tell it to use, causing it to fail when attempting to add experts to perstack.toml.

Fix in Cursor Fix in Web


# ----------------------------------------------------------------------------

Expand All @@ -663,6 +666,7 @@ delegates = ["functional-manager", "usability-manager"]
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"
pick = ["attemptCompletion"]

# ----------------------------------------------------------------------------

Expand All @@ -678,6 +682,7 @@ delegates = ["expert-tester"]
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"
pick = ["attemptCompletion"]

# ----------------------------------------------------------------------------

Expand All @@ -693,6 +698,7 @@ delegates = ["expert-tester"]
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"
pick = ["attemptCompletion"]

# ----------------------------------------------------------------------------

Expand All @@ -707,6 +713,7 @@ ${EXPERT_TESTER_INSTRUCTION}
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"
pick = ["exec", "attemptCompletion"]

# ----------------------------------------------------------------------------

Expand All @@ -721,5 +728,6 @@ ${REPORT_GENERATOR_INSTRUCTION}
type = "mcpStdioSkill"
command = "npx"
packageName = "@perstack/base"
pick = ["attemptCompletion"]
`
}