refactor(create-expert): consolidate duplicate property definitions with sync notes

[FL4TLiN3]

Summary

Adds synchronization notes between create-expert-toml.ts and agents-md-template.ts for the Framework Quality Properties that are defined in both files.

Changes

1. Renamed "Perstack Properties" to "Framework Quality Properties"

   • Matches Docs: document Perstack Properties (PS-XXX) framework or internalize as create-expert-only concept #379's terminology change
   • Clarifies these are internal to create-expert framework

2. Removed PS-XXX identifiers

   • Consistency with Docs: document Perstack Properties (PS-XXX) framework or internalize as create-expert-only concept #379

3. Added synchronization notes

   • Both files now include: "Note: Also defined in [other file] - keep synchronized"
   • Makes duplication explicit and prevents drift

4. Added documentation references

   • Both files reference docs/making-experts/best-practices.md for public guidelines

Why Not Full Consolidation

Full consolidation (extracting to a shared module) would require refactoring the template string structure significantly. The synchronization notes approach:

• Makes duplication explicit
• Prevents accidental drift
• Low-risk change
• Can be improved later if needed

Closes #385

Test plan

• CI passes
• No behavior changes expected

---

Note

Clarifies duplication of Framework Quality Properties and reduces drift risk by adding explicit sync notes.

• Adds cross-references in agents-md-template.ts and create-expert-toml.ts noting the properties are defined in both files and must be kept synchronized
• Introduces a changeset for a patch release

^{Written by Cursor Bugbot for commit 1fa212e. This will update automatically on new commits. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[cursor]

Internal sync notes leak into generated output

The synchronization notes are placed inside template strings rather than as code comments. In agents-md-template.ts, the note referencing create-expert-toml.ts will appear in every generated AGENTS.md file that users see. In create-expert-toml.ts, the note referencing agents-md-template.ts becomes part of the PROPERTY_EXTRACTOR_INSTRUCTION sent to the LLM. These internal developer notes reference source files that end users and LLMs don't have access to, creating confusing output.

Additional Locations (1)

• apps/create-expert/src/lib/create-expert-toml.ts#L57-L58