fix: add timeprovider fallback #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozzare
force-pushed
the
add-timeprovider-fallback
branch
from
87b5821 to
b7048df
Compare
Johannestegner
approved these changes
Jan 22, 2026
Member
Johannestegner
left a comment
Johannestegner
left a comment
There was a problem hiding this comment.
Looks good to me!
In the future (if/when we add net4.8 tests) we might have to add the #if compiler directive in the tests as well (as they will currently just use the "real" time provider. But thats an issue for that day!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Add a fallback TimeProvider for versions prior to
.NET 8Related issue
Motivation
Checklist