Format all the .c and .h files #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Thank you for maintaining the project and thanks to everybody who contributes in any ways... @fzerorubigd (or any other maintainer for that matter), please do not accept changes that are not formatted properly. |
Collaborator
|
Thanks, but for checking as of now, either we need to make sure there is a
tool automatically checking it, or it is not possible to "eyeball check" it
…On Tue, Apr 22, 2025, 7:11 PM M. Yas. Davoodeh ***@***.***> wrote:
Thank you for maintaining the project and thanks to everybody who
contributes in any ways...
@fzerorubigd <https://github.com/fzerorubigd> (or any other maintainer
for that matter), please do not accept changes that are not formatted
properly.
—
Reply to this email directly, view it on GitHub
<#28 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHEJ46O6FDHGTWOI7REO4L22ZZ3FAVCNFSM6AAAAAB2Q3RNH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRRHE3DSNRUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*Davoodeh* left a comment (persiancal/jcal#28)
<#28 (comment)>
Thank you for maintaining the project and thanks to everybody who
contributes in any ways...
@fzerorubigd <https://github.com/fzerorubigd> (or any other maintainer
for that matter), please do not accept changes that are not formatted
properly.
—
Reply to this email directly, view it on GitHub
<#28 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHEJ46O6FDHGTWOI7REO4L22ZZ3FAVCNFSM6AAAAAB2Q3RNH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRRHE3DSNRUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Author
|
@fzerorubigd, Anytime! Alright then I make a hook to automatically check for it before committing if enabled. We can also add it into the automatic build process. I don't see any downsides to it. Although, just to mention and judging from the recent commits, I don't think "eyeballing" it is that of a long shot either. |
Davoodeh
added a commit
to Davoodeh/jcal_c
that referenced
this pull request
Apr 25, 2025
This action, triggered on push or pull, fails if clang-format fails. This addresses the comment referenced by [1] on persiancal#28 (formatting all the sources following the minimal path examples on persiancal#23). Note that the "sources" directory is hardcoded on the action file pushed. Assuming the change of source directory is a fundamental change with a lot of considerations, no documentations were added to mention that the value used in this file must be synchronized with the directory name on the tree. Suppose this comment suffices. [1]: persiancal#28 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the new format is accepted (#23), this changes everything and puts the blame entirely on me.
This compiles with no issue as there are no behavioral changes. Tests and else were not checked but there should not be a problem.