Now checks if entries array has items #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyi1212
approved these changes
Nov 3, 2025
The helm lint failures in CI were caused by using outdated Helm 3.3.4 (from 2020). The template syntax `ne .Values.server.enabled false` works correctly with modern Helm versions. Changes: - Upgraded CI Helm version from 3.3.4 to 3.19.0 (latest stable) - Reverted commit b82a8f2 template changes (not needed with modern Helm) Testing confirmed: - All helm lint tests pass with Helm 3.14+ and 3.19.0 - Customer issue (empty dataConfigSources entries) remains fixed - Original template syntax is compatible with modern Helm 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The k3d cluster startup was failing due to using outdated versions: - k3d-action v1.4.0 (from 2021) → v2.4.0 (latest, Jan 2024) - k3s v1.18.18 (from 2021) → v1.28.8 (modern, stable) - k3d config API v1alpha2 → v1alpha4 (current) Changes: - Upgraded k3d-action from v1.4.0 to v2.4.0 - Updated k3d config API version from v1alpha2 to v1alpha4 - Upgraded k3s image from v1.18.18-k3s1 to v1.28.8-k3s1 This should resolve the "server is currently unable to handle the request" errors seen during cluster startup in CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The k3d v1alpha4 schema requires different structure: - name field must be under metadata - extraServerArgs changed to extraArgs with arg/nodeFilters structure - Each disable flag must be a separate arg entry Changes: - Moved name under metadata wrapper - Changed extraServerArgs to extraArgs - Split --disable flags into separate arg entries with nodeFilters - Each arg targets server:* nodes This fixes the schema validation errors: - "Additional property name is not allowed" - "Additional property extraServerArgs is not allowed" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The e2e tests were using incorrect service names that didn't match
the actual services created by Helm.
Issue: When release name != chart name, Helm generates service names as:
{release-name}-{chart-name}-{component}
In this case:
- Release: myopal
- Chart: opal
- Generated names: myopal-opal-server, myopal-opal-client
But tests were looking for: myopal-server, myopal-client
Changes:
- deploy.sh: myopal-server → myopal-opal-server
- test.sh: myopal-client → myopal-opal-client
- test.sh: myopal-server → myopal-opal-server
This fixes the "service not found" error in CI e2e tests.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
The OPAL client container doesn't have curl installed, causing the test to fail when trying to exec curl commands inside the container. Error: exec: "curl": executable file not found in $PATH Solution: - Use kubectl run with curlimages/curl image to query OPA from outside - Changed DATA_URL from localhost:8181 to service name myopal-opal-client:8181 - This matches the pattern used in templates/tests/e2e.yaml Changes: - Replaced kubectl exec with kubectl run --rm for curl commands - Updated URL to use service name instead of localhost 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.