Skip to content

Conversation

@danyi1212
Copy link
Contributor

@danyi1212 danyi1212 commented Nov 23, 2025

Note

Removes PDP-Vanilla image build/publish steps from the release workflow, keeping only the main PDP image build and downstream steps.

  • CI Release Workflow (.github/workflows/release.yml):
    • Deprecate PDP-Vanilla build:
      • Remove docker/build-push-action steps that built and pushed permitio/pdp-v2-vanilla for both prereleases and official releases.
      • Retain the pre-build step generating permit_pdp_version for PDP-Vanilla job.
    • Unchanged: Main PDP build/publish logic (permitio/pdp-v2) and ECS service redeploy remain intact.

Written by Cursor Bugbot for commit c8d4332. Configure here.

@danyi1212 danyi1212 self-assigned this Nov 23, 2025
@linear
Copy link

linear bot commented Nov 23, 2025

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 12

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Incomplete job deprecation leaves orphaned setup steps

The build-and-push-pdp-vanilla job now performs Docker login, QEMU setup, Buildx setup, and creates permit_pdp_version file, but the actual build and push steps were removed. These setup steps now serve no purpose and waste CI resources. The job either needs complete removal or the remaining orphaned steps should be deleted.

.github/workflows/release.yml#L29-L37

- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Pre build - for PDP-Vanilla
run: echo "${{ github.event.release.tag_name }}" | cut -d '-' -f 1 > permit_pdp_version

Fix in Cursor Fix in Web


@danyi1212 danyi1212 merged commit 4fd1a05 into main Nov 30, 2025
5 checks passed
@danyi1212 danyi1212 deleted the dan/per-13368-deprecate-pdp-vanilla branch November 30, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants