compiler/module: Catch panics properly. #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if a compiler panics, the error is recorded into a local variable defined in the scope of a Compile* function. This variable however has no direct relation to the return value of the function. So if a panic actually happens, the last `return` statement is not executed and the function just returns empty default values. This behaviour results in errors being silently discurded, the concequences of such errors are typically discovered much later during execution (e.g., as index out of bounds panics in vm.go). After this change, panics in Compile* functions are always propagated to the caller as errors.
Author
|
Ok, seems to be a duplicate of #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a compiler panics, the error is recorded into a local
variable defined in the scope of a Compile* function. This variable
however has no direct relation to the return value of the function.
So if a panic actually happens, the last
returnstatement is notexecuted and the function just returns empty default values.
This behaviour results in errors being silently discurded, the
concequences of such errors are typically discovered much later during
execution (e.g., as index out of bounds panics in vm.go).
After this change, panics in Compile* functions are always propagated
to the caller as errors.