Closed
Conversation
| .map_err(|_| Error::NotEnoughBytes)?; | ||
|
|
||
| let mut ie_payload = vec![0x00; data_length as usize]; | ||
| let mut ie_payload = vec![0x00; ie_length as usize]; |
There was a problem hiding this comment.
The IE payload should have the IE length, not data length
| MTFrame { | ||
| header: MTHeader { | ||
| length: 0x26, | ||
| length: 0x1e, |
Comment on lines
+308
to
+313
| pub struct IeItem { | ||
| pub type_long: bool, | ||
| pub id: u8, | ||
| pub content_len: u16, | ||
| pub content: Vec<u8>, | ||
| } |
There was a problem hiding this comment.
Used to parse the IE payload in WS Async frames
Author
There was a problem hiding this comment.
Where have you found the info describing these fields?
I couldn't find it in the stack-cop-interface guide.
Author
guilherme-akira
force-pushed
the
fix-wsasyncreq-length
branch
from
4ba8ad2 to
1890682
Compare
guilherme-akira
force-pushed
the
fix-wsasyncreq-length
branch
from
1890682 to
c48e178
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR: