Skip to content

Improve focus-out detection #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivaynberg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve focus-out detection #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39f8a4c
improve focus-out detection
ivaynberg May 27, 2011
8300d63
fix a bug where time picker would not be shown once the input was cli…
ivaynberg Jun 1, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions jquery.timePicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,19 @@
if ($tpDiv.is(":visible")) {
return false;
}

var clickOutListener=function(e) {
var contains=false;
$(e.target).parents().each(function() { contains|=(this===$tpDiv.first().get()); return contains; });
contains|=(this===elm);
if (!contains) {
hidePicker($tpDiv);
}

};
$tpDiv.data("clickOutListener", clickOutListener);
$(document).delegate("*", "click", clickOutListener);

$("li", $tpDiv).removeClass(selectedClass);

// Position
Expand Down Expand Up @@ -120,7 +133,7 @@
// Hide timepicker on blur
$(elm).blur(function() {
if (!tpOver) {
$tpDiv.hide();
hidePicker($tpDiv);
}
});
// Keypress doesn't repeat on Safari for non-text keys.
Expand Down Expand Up @@ -182,7 +195,7 @@
return false;
break;
case 27: // Esc
$tpDiv.hide();
hidePicker($tpDiv);
return false;
break;
}
Expand Down Expand Up @@ -217,6 +230,13 @@

// Private functions.

function hidePicker($tpDiv) {
var listener=$tpDiv.data("clickOutListener");
$(document).undelegate("*", "click", listener);
$tpDiv.removeData("clickOutListener");
$tpDiv.hide();
}

function setTimeVal(elm, sel, $tpDiv, settings) {
// Update input field
elm.value = $(sel).text();
Expand All @@ -227,7 +247,7 @@
elm.focus();
}
// Hide picker
$tpDiv.hide();
hidePicker($tpDiv);
}

function formatTime(time, settings) {
Expand Down