pcp2openmetrics: resolves RHEL-138467 #2448
Merged
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcohen
reviewed
Jan 16, 2026
|
|
||
| # Set delay mode, interpolation | ||
| if self.context.type != PM_CONTEXT_ARCHIVE: | ||
| if self.context.type == PM_CONTEXT_ARCHIVE: |
Contributor
There was a problem hiding this comment.
How is this going to work with live data? I don't think that inverting the sense of the test is the right thing to do to turn on the interpolation. Isn't that going to delay things for the archive. Looking at the pmrep.py has:
# Set delay mode, interpolation
if self.context.type == PM_CONTEXT_ARCHIVE:
self.delay = 1
self.interpol = 1
And it initialize interpol in PMReporter to 1 with the following rather than 0 in pcp2openmetrics.py:
self.interpol = 1
Contributor
There was a problem hiding this comment.
"RHEL-11406" in the comment doesn't look correct. Should that be RHEL-138467?
multi-instance metrics failing when queried with singular metrics from archive. Turning interpolation on resolves this issue. Additional code added to fix missing headers when 2+ metrics are queried together.
lmchilton
force-pushed
the
pcp2openmetrics-archive-issue
branch
from
8a69710 to
6347895
Compare
lmchilton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multi-instance metrics failing when queried with
singular metrics from archive. Turning interpolation on resolves this issue. Additional code added to fix missing headers when 2+ metrics are queried together.