Replaced ERR_EXPLAIN with CRASH_NOW_MSG for 3.2.1 compatibility#3
Open
yeslayla wants to merge 2 commits intoperdugames:masterfrom
Open
Replaced ERR_EXPLAIN with CRASH_NOW_MSG for 3.2.1 compatibility#3yeslayla wants to merge 2 commits intoperdugames:masterfrom
ERR_EXPLAIN with CRASH_NOW_MSG for 3.2.1 compatibility#3yeslayla wants to merge 2 commits intoperdugames:masterfrom
Conversation
|
Will it not be better when we use |
Author
It would probably be a better solution, though this PR is about a year old now, so I'm not sure how stale it is. |
Author
|
Updated commit, implements changes suggested by @demurzasty and makes the project compatible with stable and 3.3rc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced error messaging functions to allow GDNet3 to build for Godot 3.2.1
Related Godot PR: godotengine/godot#33517