Skip to content

Conversation

@pranavz28
Copy link

@pranavz28 pranavz28 commented Oct 10, 2025

This pull request updates development dependencies to support current browser versions and improves cross-browser test reliability. The most important changes include upgrading Selenium-related packages, adding fallback logic to run tests in Chrome if Firefox is unavailable, and updating documentation to reflect these changes.

Dependency and tooling updates:

  • Upgraded development dependencies in package.json to latest versions: @percy/cli (1.30.11 → 1.31.2), selenium-webdriver (4.1.1 → 4.36.0), chromedriver (added at 141.0.1), geckodriver (3.0.1 → 6.0.2), http-server (0.11.1 → 14.1.1), and todomvc-app-css (2.2.0 → 2.4.3).

  • Updated README.md to document these dependency upgrades and provide guidance on configuring browser binaries via environment variables for compatibility.

Test reliability and cross-browser support:

  • Enhanced test setup in tests/test.js to first attempt running Selenium tests in Firefox, and automatically fall back to Chrome headless mode if Firefox is unavailable, improving reliability across environments. [1] [2]
  • Added required imports and notes for chromedriver in tests/test.js to ensure the binary is available in PATH for Chrome-based tests.

UI improvement:

  • Made the "Clear completed" button bold in index.html for better visibility.

@pranavz28 pranavz28 requested a review from a team as a code owner October 10, 2025 08:11
index.html Outdated
</li>
</ul>
<button class="clear-completed">Clear completed</button>
<button class="clear-completed" style="font-weight:bold">Clear completed</button>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants