PSMDB-1947 LDAP User Cache Refresh options#1115
Conversation
There was a problem hiding this comment.
Pull request overview
Adds documentation for new LDAP user cache refresh configuration options to help operators tune LDAP authentication performance.
Changes:
- Documented two new LDAP cache refresh server parameters:
ldapUserCacheRefreshIntervalandldapShouldRefreshUserCacheEntries. - Added brief explanation of how the refresh strategy relates to existing cache invalidation behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - When set to `false`, all `$external` users are evicted from the cache at intervals defined by `ldapUserCacheInvalidationInterval`. This preserves the behavior that existed prior to the introduction of `ldapUserCacheRefreshInterval` and `ldapShouldRefreshUserCacheEntries`. | ||
|
|
||
| The default value is `false` (expiration-based invalidation using `ldapUserCacheInvalidationInterval`), to maintain backward-compatible behavior unless interval-based refreshing is explicitly enabled. |
There was a problem hiding this comment.
This section references ldapUserCacheInvalidationInterval but doesn't explain what it is or where to configure it, and it appears to be undocumented elsewhere in docs/. Consider adding a brief definition (units/default) and/or linking to the place where ldapUserCacheInvalidationInterval is documented so readers can understand the false behavior path.
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Added a description of ldapUserCacheInvalidationInterval as a new bullet point explaining that it controls how long (in seconds) cached LDAP user entries remain valid before they expire and are evicted, and noting that it applies when ldapShouldRefreshUserCacheEntries is set to false. Commit: abd4e0b
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
The description of ldapUserCacheInvalidationInterval is already present in the file (line 130) from commit abd4e0b. No further changes are needed.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
igorsol
left a comment
There was a problem hiding this comment.
Approved but please fix issues found by copilot
Agent-Logs-Url: https://github.com/percona/psmdb-docs/sessions/81d763b8-97e9-4465-9940-7a368d54973c Co-authored-by: rasika-chivate <95711051+rasika-chivate@users.noreply.github.com>
ldapUserCacheRefreshIntervalparameterldapShouldRefreshUserCacheEntriesparameter with true/false semantics and defaultldapUserCacheInvalidationInterval(units, what it controls, when it applies)ldapShouldRefreshUserCacheEntries$externalformatting typo📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.