Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5212 +/- ##
==========================================
- Coverage 47.76% 47.72% -0.05%
==========================================
Files 410 410
Lines 41967 41967
==========================================
- Hits 20047 20030 -17
- Misses 19943 19954 +11
- Partials 1977 1983 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14887
Link to the Feature Build: SUBMODULES-4291
This pull request introduces several improvements to the development environment, build system, and documentation for PMM Server. The most significant changes include refactoring Makefile usage, updating environment configuration and documentation, and adding new development utilities. These updates aim to streamline local development, clarify configuration, and improve maintainability.
Build system and Makefile refactoring:
Makefileis now the central entry point for development commands, incorporating targets from.devcontainer/Makefileand removingMakefile.include. This unifies and simplifies build and development workflows. (Makefile[1].devcontainer/Makefile[2]Makefile.include[3].devcontainer/Makefile(formerlyMakefile.devcontainer) has been renamed and refactored with more descriptive target names (e.g.,psql-managed,dlv-attach) and improved comments. (.devcontainer/Makefile[1] [2]Makefile.devcontainerasMakefile, reflecting the new Makefile structure. (.devcontainer/Dockerfile.devcontainer/DockerfileL17-L18)Environment configuration and documentation:
.env.examplefile has been rewritten with clearer variable names and documentation, providing better guidance for local configuration. (.env.example.env.exampleL1-R17)docker-compose.dev.ymlinstead ofdocker-compose.yml, clarifying the intended use of each compose file. (.github/instructions/managed.instructions.md[1]AGENTS.md[2]Development workflow and CI improvements:
.github/workflows/managed.yml[1] [2] [3].github/workflows/api-tests.yml.github/workflows/api-tests.ymlL70)New development utilities:
dev/my.cnf), log rotation (dev/mysql.logrotate), and sysbench benchmarking (dev/sysbench-ps.sh) have been added to facilitate local testing and performance evaluation. (dev/my.cnf[1]dev/mysql.logrotate[2]dev/sysbench-ps.sh[3]Minor corrections:
agent/cmd/pmm-agent-entrypoint/main.goagent/cmd/pmm-agent-entrypoint/main.goL43-R45)These changes collectively modernize and clarify the development setup, making it easier for contributors to get started and maintain consistency across environments.