Draft
Conversation
…tings hook with query invalidation Made-with: Cursor
… forms - Add Settings page with SSH Key, Metrics Resolution, Advanced Settings tabs - Add Settings.messages.ts with all copy from Grafana - Add placeholder form components (to be implemented in next commits) - Fix useUpdateSettings onSuccess signature for react-query v5 - Fix updateSnoozeDuration optional handling in useSnooze Made-with: Cursor
…dateSettings Made-with: Cursor
Made-with: Cursor
…M_SETTINGS_URL Made-with: Cursor
…ding test Made-with: Cursor
matejkubinec
changed the title
- Updated esbuild packages in yarn.lock from version 0.21.5 to 0.25.12. - Added scrollbar stability in GlobalStyles for improved UI experience. - Refactored Page component layout to ensure proper flex behavior and added a Divider for better separation of the footer. - Enhanced Sidebar component for better usability on narrow screens, so now it overlaps, instead of pushing, to open it in smaller screens.
Contributor
|
|
- Promoted Metrics resolution as the 1st tab. - Updated text capitalization in Settings.messages. - Improved layout and styling in MetricsResolutionForm for better accessibility. - Transformed the MetricsResolutionForm into inline info, for better accessibility.
- Updated tooltip texts and labels in Settings.messages for clarity. - Refined layout and styling in AdvancedSettingsForm and SshKeyForm for better accessibility and usability. - Added a sticky footer to all tabs for improved action visibility during form submission. - Adjusted spacing and alignment in various components to enhance overall UI consistency.
- Added a new 'surface' prop to the Page component for customizable background styling. - Integrated GlobalStyles to manage background color based on the 'surface' prop. - Updated Settings page to utilize the new 'surface' prop for improved visual consistency.
Contributor
|
Done with my review and proposals for improvement ✔️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5163 +/- ##
=======================================
Coverage 47.70% 47.71%
=======================================
Files 410 410
Lines 41967 41967
=======================================
+ Hits 20022 20026 +4
+ Misses 19964 19962 -2
+ Partials 1981 1979 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14930
SUBMODULES-4273
Grafana PR: percona/grafana#891
Screenshots:
