PMM-12832 Timeouts for exporters. by JiriCtvrtka · Pull Request #5134 · percona/pmm

JiriCtvrtka · 2026-03-12T08:37:50Z

managed/models/agent_model.go

codecov · 2026-03-20T10:40:02Z

Codecov Report

❌ Patch coverage is 83.42541% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.66%. Comparing base (e882771) to head (0eb4514).
⚠️ Report is 1 commits behind head on v3.

Files with missing lines	Patch %	Lines
managed/services/inventory/agents.go	70.58%	20 Missing ⚠️
managed/models/agent_model.go	87.38%	10 Missing and 4 partials ⚠️
managed/services/converters.go	73.33%	4 Missing and 4 partials ⚠️
managed/models/database.go	0.00%	1 Missing and 1 partial ⚠️
.../commands/inventory/add_agent_external_exporter.go	0.00%	1 Missing ⚠️
...n/commands/inventory/add_agent_mongodb_exporter.go	0.00%	1 Missing ⚠️
...in/commands/inventory/add_agent_mysqld_exporter.go	0.00%	1 Missing ⚠️
...dmin/commands/inventory/add_agent_node_exporter.go	0.00%	1 Missing ⚠️
.../commands/inventory/add_agent_postgres_exporter.go	0.00%	1 Missing ⚠️
.../commands/inventory/add_agent_proxysql_exporter.go	0.00%	1 Missing ⚠️
... and 10 more

Additional details and impacted files

@@            Coverage Diff             @@
##               v3    #5134      +/-   ##
==========================================
+ Coverage   47.15%   48.66%   +1.51%     
==========================================
  Files         410      411       +1     
  Lines       41969    42093     +124     
==========================================
+ Hits        19790    20485     +695     
+ Misses      20234    19555     -679     
- Partials     1945     2053     +108

Flag	Coverage Δ
admin	`35.81% <39.13%> (+0.01%)`	⬆️
agent	`53.04% <ø> (+2.28%)`	⬆️
managed	`49.19% <86.43%> (+1.49%)`	⬆️
vmproxy	`72.09% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JiriCtvrtka · 2026-03-20T10:45:30Z

managed/models/agent_model.go


 // DSN returns a DSN string for accessing a given Service with this Agent (and an implicit driver).
-func (s *Agent) DSN(service *Service, dsnParams DSNParams, tdp *DelimiterPair, pmmAgentVersion *version.Parsed) string { //nolint:cyclop,maintidx
+func (a *Agent) DSN(service *Service, dsnParams DSNParams, tdp *DelimiterPair, pmmAgentVersion *version.Parsed) string { //nolint:cyclop,maintidx


Not related, but we discussed this on Go BE.

ademidoff · 2026-03-20T15:20:33Z

managed/models/agent_model.go

+		MongoDBExporterType,
+		PostgresExporterType,
+		ProxySQLExporterType,
+		RDSExporterType,


QQ: Doesn't RDS Exporter have a higher default timeout?

Right, it has usually around 90% of scrape interval. Will check it.

Right now only scrape interval and scrape timeout from configs is used. Timeout in DSN is removed and not used like in v3.

ademidoff · 2026-03-20T15:29:21Z

managed/models/agent_model_test.go

 		}

-		expected := "redis://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345"
+		expected := "redis://username:s3cur3%20p%40$$w0r4.@1.2.3.4:12345?dial_timeout=1s"


From what I see in the documentation, Redix exporter does not support such a parameter in their connection string. They seem to use the --connection-timeout parameter or an env variable.

Let's double check to be sure.

True, no DSN param, but flag. Should be correct right now. Also test file for this is added. Thank you.

ademidoff · 2026-03-21T09:26:57Z

managed/services/management/valkey.go

 			return err
 		}

+		exporterOptions := models.ExporterOptions{


Is it justified to have it as a separate variable vs inline as before?

Changed to original format.

ademidoff · 2026-03-21T09:28:55Z

managed/services/victoriametrics/scrape_configs.go

+// (node / external / RDS scrape of exporter HTTP). By Prometheus rule, scrape_timeout
+// cannot exceed scrape_interval, so PMM caps it at 0.9 of scrape interval:
+// https://prometheus.io/docs/prometheus/latest/configuration/configuration/
+func applyExporterScrapeTimeout(cfg *config.ScrapeConfig, agent *models.Agent) {


Method names in Go don't need to be that long, I guess exporterScrapeTimeout is good enough, similar to the one right below :)

Sure, renamed

ademidoff · 2026-03-21T09:35:35Z

managed/services/converters.go

 			ExtraDsnParams:            agent.MySQLOptions.ExtraDSNParams,
-		}, nil
+		}
+		if agent.ExporterOptions.Timeout != 0 {


I'm not sure, but I'm wondering if this if statement is not redundant.

agent.ExporterOptions.Timeout is not pointer so check could be skipped, but exporter.Timeout is so without this it will set 0 even for non set timeouts. With check it if more visible if it was really set or not.

…PMM-12832-exporter-timeouts

maxkondr · 2026-03-23T12:07:04Z

admin/commands/inventory/add_agent_external_exporter.go

 	CustomLabels  map[string]string `mapsep:"," help:"Custom user-assigned labels"`
 	PushMetrics   bool              `help:"Enables push metrics model flow, it will be sent to the server by an agent"`
 	TLSSkipVerify bool              `help:"Skip TLS certificate verification"`
+	Timeout       string            `help:"Connection timeout to use for exporter (e.g. 1s, 500ms)"`


Suggested change

Timeout string `help:"Connection timeout to use for exporter (e.g. 1s, 500ms)"`

Timeout *time.Duration `placeholder:"DURATION" help:"Connection timeout to use for exporter (e.g. 1s, 500ms)"`

here and at the rest of commands

maxkondr · 2026-03-23T13:17:03Z

api/inventory/v1/agents.proto

  // Metrics resolution for this agent.
  common.MetricsResolutions metrics_resolutions = 15;
+  // Connection timeout for exporter (if set).
+  google.protobuf.Duration timeout = 16;


there may be many timeouts: connection, fetch metrics, etc.
it is better to explicitly define that timeout is ment here like connection_timeout

maxkondr · 2026-03-23T13:19:04Z

api/management/v1/agent.proto

  // Real-Time Analytics options.
  inventory.v1.RTAOptions rta_options = 42;
+  // Connection timeout for exporter (if set).
+  google.protobuf.Duration timeout = 43;


the same here and in the rest of the*.proto files

maxkondr · 2026-03-23T13:20:55Z

api/management/v1/rds.proto

  // Maximum number of exporter connections to PostgreSQL instance.
  int32 max_postgresql_exporter_connections = 33;
+  // Connection timeout for exporter (if set).
+  google.protobuf.Duration timeout = 35;


Suggested change

google.protobuf.Duration timeout = 35;

google.protobuf.Duration timeout = 34;

maxkondr · 2026-03-23T13:30:40Z

managed/models/agent_model.go

+	switch a.AgentType {
+	case NodeExporterType,
+		MySQLdExporterType,
+		MongoDBExporterType,
+		PostgresExporterType,
+		ProxySQLExporterType,
+		AzureDatabaseExporterType,
+		ExternalExporterType,
+		ValkeyExporterType:
+		return 1 * time.Second
+	default:
+	}


should it be there if effectiveDialTimeoutFallbackSec is used as fallback?

maxkondr · 2026-03-23T13:49:07Z

managed/models/dsn_helpers.go

-			QANMongoDBMongologAgentType,
-			MongoDBExporterType,
-			RTAMongoDBAgentType)
+			MongoDBExporterType)


Why RTA and MongoLog agents types have been removed?

Why MongoProfiler type is kept?

I think I resolved conflict during merging main wrong. I will fix it, thanks

PMM-12832 Rough implementation.

d01d2da

github-code-quality bot found potential problems Mar 12, 2026

View reviewed changes

managed/models/agent_model.go Fixed Show fixed Hide fixed

JiriCtvrtka and others added 28 commits March 12, 2026 09:49

PMM-12832 Fix.

ca36e37

Merge branch 'v3' into PMM-12832-exporter-timeouts

eb9dc4e

PMM-12832 More exporters, refactor.

342e4c0

Merge remote-tracking branch 'origin/PMM-12832-exporter-timeouts' into …

75c0854

…PMM-12832-exporter-timeouts

PMM-12832 Another parts.

e009b06

PMM-12832 Mongo change, list.

fe76cec

PMM-12832 Changes, refactor.

3dd7cb4

PMM-12832 Refactor of agent model.

3831afd

PMM-12832 Lint.

27895b3

PMM-12832 Inventory timeout for all.

dad3e75

Merge branch 'v3' into PMM-12832-exporter-timeouts

64d37ca

PMM-12832 Add change func after merge.

d1c530e

PMM-12832 Fix for now.

3c358f0

PMM-12832 Changes.

658fc92

PMM-12832 Fix tests.

58db609

PMM-12832 Changes.

b3d65c7

PMM-12832 Changes.

8f44fc6

PMM-12832 Changes.

c329c2a

PMM-12832 Changes.

1b924cd

PMM-12832 Change for RTA.

098d50e

PMM-12832 Fix.

5811d1b

PMM-12832 Fix.

42f5b86

PMM-12832 Fix.

69ed781

PMM-12832 Refactor.

bccea8d

PMM-12832 Remove not related types.

80226ed

PMM-12832 Changes.

c6dd6e7

PMM-12832 Remote, valkey, etc.

963a998

PMM-12832 Fix.

4e09994

JiriCtvrtka and others added 9 commits March 18, 2026 15:58

PMM-12832 Lint.

04514be

PMM-12832 Lint.

64a5e7a

PMM-12832 New tests.

fb125cb

Merge branch 'v3' into PMM-12832-exporter-timeouts

f503841

PMM-12832 Better comment.

fe7a7fe

PMM-12832 Fix for missed parts.

3949531

Merge branch 'v3' into PMM-12832-exporter-timeouts

0a05b27

PMM-12832 Format.

8632984

Merge remote-tracking branch 'origin/PMM-12832-exporter-timeouts' into …

a0a72b8

…PMM-12832-exporter-timeouts

JiriCtvrtka mentioned this pull request Mar 20, 2026

PMM-12832 Timeouts for exporters. Percona-Lab/pmm-submodules#4275

Draft

percona deleted a comment from codecov bot Mar 20, 2026

JiriCtvrtka commented Mar 20, 2026

View reviewed changes

JiriCtvrtka marked this pull request as ready for review March 20, 2026 13:53

JiriCtvrtka requested a review from a team as a code owner March 20, 2026 13:53

JiriCtvrtka requested review from ademidoff and maxkondr and removed request for a team March 20, 2026 13:53

Merge branch 'v3' into PMM-12832-exporter-timeouts

69fd130

ademidoff reviewed Mar 21, 2026

View reviewed changes

JiriCtvrtka added 6 commits March 21, 2026 12:40

PMM-12832 Valkey refactor.

afefbea

Merge remote-tracking branch 'origin/PMM-12832-exporter-timeouts' into …

1c01e3a

…PMM-12832-exporter-timeouts

PMM-12832 Requested changes.

c6246b9

PMM-12832 RDS fix.

c84fc3f

PMM-12832 Correct timeout flag for Valkey/Redis.

089c328

PMM-12832 Lint.

0eb4514

JiriCtvrtka requested a review from ademidoff March 22, 2026 14:35

maxkondr reviewed Mar 23, 2026

View reviewed changes

	Timeout string `help:"Connection timeout to use for exporter (e.g. 1s, 500ms)"`
	Timeout *time.Duration `placeholder:"DURATION" help:"Connection timeout to use for exporter (e.g. 1s, 500ms)"`

	google.protobuf.Duration timeout = 35;
	google.protobuf.Duration timeout = 34;

Conversation

JiriCtvrtka commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JiriCtvrtka Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JiriCtvrtka commented Mar 12, 2026 •

edited

Loading

codecov bot commented Mar 20, 2026 •

edited

Loading

JiriCtvrtka Mar 22, 2026 •

edited

Loading