Draft
Conversation
- Settings: Add Adre struct (Enabled, URL), IsAdreEnabled(), GetAdreURL() - ChangeSettingsParams: Add EnableAdre, AdreURL for updates - New package managed/services/adre: HolmesGPT HTTP client - Models(), Chat(), ChatStream(), Investigate(), InvestigateStream() - Uses HolmesGPT /api/chat, /api/stream/chat, /api/investigate, etc. Made-with: Cursor
- Introduced new HTTP handlers for ADRE settings, models, chat, alerts, and investigation endpoints in the pmm-managed service. - Updated the Grafana auth server to include permissions for ADRE routes. - Added navigation support for ADRE in the UI, including a dedicated page and chat widget. - Enhanced the main application layout to incorporate the ADRE chat widget. Made-with: Cursor
theTibi
requested review from
JiriCtvrtka,
fabio-silva,
matejkubinec and
maxkondr
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## tibi-test #5118 +/- ##
=============================================
- Coverage 47.11% 46.69% -0.42%
=============================================
Files 421 551 +130
Lines 42311 44681 +2370
Branches 0 590 +590
=============================================
+ Hits 19933 20866 +933
- Misses 20384 21725 +1341
- Partials 1994 2090 +96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Modified README to clarify ADRE settings access for viewers and admins. - Enhanced ChatStream functionality to handle streaming requests more effectively. - Added URL validation in PostSettings handler to ensure proper format. - Updated Grafana auth server to allow viewer access to ADRE settings. - Improved error handling in AdrePage to manage loading states and forbidden access. - Refactored AdreChatWidget to remove unused model fetching logic. - Introduced a utility function to parse and extract text from SSE data in chat streams. Made-with: Cursor
- Updated README to specify that alerts require ADRE to be enabled. - Modified ChatStream to avoid mutating the original request. - Added comprehensive tests for ADRE settings and model retrieval. - Improved URL validation in PostSettings handler to ensure proper format and provide clearer error messages. - Enhanced error handling in various ADRE handlers to ensure consistent responses. Made-with: Cursor
- Changed the ChatStream HTTP request URL from /api/stream/chat to /api/chat for consistency. - Enhanced error message formatting in ChatStream to clarify the source of errors related to the new endpoint. Made-with: Cursor
- Updated ADRE handlers to fetch alerts from Grafana's Alertmanager instead of VMAlert. - Modified README to reflect the change in alert source. - Enhanced error handling and added tests for the new alert fetching functionality. - Refactored related components to improve clarity and maintainability. Made-with: Cursor
- Added support for Basic Authentication in the ADRE client by encoding credentials in the Authorization header. - Updated README to include instructions for using authentication with HolmesGPT URLs. - Improved error handling in the InvestigateStream method to clarify endpoint usage. Made-with: Cursor
- Updated the buildInvestigatePayload function to include optional context and subject fields as records. - Improved the structure of the subject field to encapsulate alert details more effectively. - Ensured that the context field provides additional information about the alert source and count. Made-with: Cursor
…handling - Updated adreChatStream to accept a callback for both content and reasoning chunks, improving the response structure. - Refactored SSE data parsing to return content and reasoning separately, enhancing clarity and usability. - Modified AdreChatPanel to store and display reasoning alongside chat messages, improving user experience. - Improved local storage handling to accommodate reasoning data, ensuring persistence across sessions. Made-with: Cursor
- Wrapped the main content of AdrePage in a Box component with a dark background and white text for improved visibility. - Maintained the existing Stack structure while ensuring proper styling and layout consistency. Made-with: Cursor
…drePage styling - Added a new location block in the NGINX configuration for ADRE streaming endpoints, setting a longer timeout for requests. - Updated AdrePage layout to improve UI presentation with adjusted margins and padding, ensuring better visibility and user experience. - Modified AdreChatPanel to include a system message in the conversation history, enhancing context for the AI assistant. Made-with: Cursor
- Added new parameters for chat and investigation prompts, along with a default chat mode in ChangeSettingsParams. - Updated settings validation to enforce maximum byte limits for prompts and ensure valid default chat mode values. - Enhanced the PostSettings handler to accept and validate new prompt settings. - Modified AdrePage to include UI elements for configuring chat and investigation prompts, as well as the default chat mode. - Implemented logic in AdreChatPanel to utilize the selected chat mode and resolve prompts accordingly. Made-with: Cursor
- Introduced the PMM_ADRE_URL environment variable to set the HolmesGPT (ADRE) base URL at startup. - Updated the ParseEnvVars function to validate the ADRE_URL format and enable ADRE based on its presence. - Added unit tests for both valid and invalid ADRE_URL scenarios to ensure proper handling and error reporting. Made-with: Cursor
- Updated the DefaultInvestigationPrompt to streamline investigation workflows, emphasizing direct responses to user queries. - Clarified the use of tools for immediate answers to factual questions, enhancing the overall guidance for users in investigation mode. - Added examples of simple queries to illustrate expected interactions. Made-with: Cursor
- Added display fields for ChatPromptDisplay and InvestigationPromptDisplay in the GetSettings and PostSettings handlers to provide default values when prompts are empty. - Updated AdreChatPanel to persist assistant messages and reasoning to localStorage, ensuring better session continuity. - Refactored AdrePage to streamline state management and removed unused prompt handling logic for clarity. - Enhanced AdreAlertsPanel to display reasoning alongside investigation results, improving user interaction and understanding. Made-with: Cursor
- Introduced a new section in the README for adding custom tools via YAML and MCP servers, enhancing extensibility. - Updated adreChatStream to support progress events for tool calls, allowing real-time feedback on tool execution. - Enhanced AdreChatPanel to display progress of tool calls, improving user experience during interactions. - Added logic to manage and display the status of tool calls, providing clearer insights into ongoing processes. Made-with: Cursor
…ments, nav, routes Made-with: Cursor
…nt, tool registry, system prompt Made-with: Cursor
…container (#4461) * remove duplicate instruction from install-pmm-client/binary_package.md Prereq #5 is copied from other files, and link to itself * page outline * add instructions to deploy pmm-client as k8s pod - add instruction page - add install pmm client as k8s pod to navigation sidebar * linguistic review * fix volumeMounts name does not match PVC Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Catalina A <94133018+catalinaadam@users.noreply.github.com> Co-authored-by: Catalina A <catalina.adam@percona.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Added new messages and RPC methods for managing OTEL log parser presets, including List, Get, Add, Change, and Remove operations. - Updated the server and client interfaces to support these new functionalities. - Enhanced the Swagger and JSON specifications to document the new endpoints for log parser presets. This update improves the management capabilities of OTEL log parser presets, allowing for better customization and usage in the system.
Resolve conflicts: keep AI investigations migrations 130-133; add syslog preset as 134; SSO table drop as 135; renumber rta_options migration 126->116 to match tibi-test. Merge ADRE and OTEL retention settings, defaults, and tests. Keep PMM 2 client deprecation note in upgrade docs. Made-with: Cursor
Bumps the npm_and_yarn group with 1 update in the /ui directory: [yaml](https://github.com/eemeli/yaml). Updates `yaml` from 1.10.2 to 1.10.3 - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v1.10.2...v1.10.3) --- updated-dependencies: - dependency-name: yaml dependency-version: 1.10.3 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Fábio Silva <ffjs1993@gmail.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 6.3.0 to 6.4.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@4b73464...4a36011) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/hashicorp/go-version](https://github.com/hashicorp/go-version) from 1.8.0 to 1.9.0. - [Release notes](https://github.com/hashicorp/go-version/releases) - [Changelog](https://github.com/hashicorp/go-version/blob/main/CHANGELOG.md) - [Commits](hashicorp/go-version@v1.8.0...v1.9.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-version dependency-version: 1.9.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the go_modules group with 1 update in the /tools directory: [github.com/go-git/go-git/v5](https://github.com/go-git/go-git). Updates `github.com/go-git/go-git/v5` from 5.16.5 to 5.17.1 - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.16.5...v5.17.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-version: 5.17.1 dependency-type: indirect dependency-group: go_modules ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.5.3 to 6.0.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@1af5884...57e3a13) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.34.1 to 4.35.1. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@3869755...c10b806) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.35.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [github.com/ClickHouse/clickhouse-go/v2](https://github.com/ClickHouse/clickhouse-go) from 2.43.0 to 2.44.0. - [Release notes](https://github.com/ClickHouse/clickhouse-go/releases) - [Changelog](https://github.com/ClickHouse/clickhouse-go/blob/main/CHANGELOG.md) - [Commits](ClickHouse/clickhouse-go@v2.43.0...v2.44.0) --- updated-dependencies: - dependency-name: github.com/ClickHouse/clickhouse-go/v2 dependency-version: 2.44.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.44.0 to 1.45.0. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@631208b...02ea592) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-version: 1.45.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Implemented a new endpoint `/v1/adre/qan-insights/servicenow` to handle POST requests for creating ServiceNow tickets based on QAN insights. - Enhanced the `ChatRequest` structure to include new fields for frontend tools and decisions. - Updated the investigation response to include confidence metrics and evidence entries. - Added functionality to copy investigation details in markdown and JSON formats from the Investigation Detail Page. - Improved the QAN AI Insights page with a button to create ServiceNow tickets and display the ticket number upon creation. This update enhances the integration of QAN insights with ServiceNow, providing users with better tools for incident management.
* PMM-7-Cross AI Agents optimization * root file rename * Remove the directory trees as redundant * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Remove azure/do instructions * Remove pmm-doc from agent guides --------- Co-authored-by: Alex Demidoff <a@demidoff.me> Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* PMM-14837 Migrate grafana-dashboards to the monorepo * PMM-14837 Fix a typo * PMM-14837 Update the Contributing guide * PMM-14837 Fix the token name * PMM-14837 Provide meaningful error messages * PMM-14837 Fix the script exec path * PMM-14837 Rename the jobs * PMM-14837 Force NodeJS v24 on the labels workflow * PMM-14837 Remove snyk from ignored jobs * PMM-14837 Extract plugin versions and arch to variables * PMM-14837 Add Valkey dashboards to README * PMM-14837 Remove build timestamp as redundant * PMM-14837 Update the contributing guide * PMM-14837 Fix the panels directory path * PMM-14837 Fix dir attributes * PMM-14837 Remove redundant spec directives * PMM-14837 Sync updates with grafana-dashboards * PMM-14837 Fix the API test --------- Co-authored-by: Matej Kubinec <32638572+matejkubinec@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.79.3 to 1.80.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.79.3...v1.80.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.80.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/alecthomas/kong](https://github.com/alecthomas/kong) from 1.14.0 to 1.15.0. - [Commits](alecthomas/kong@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: github.com/alecthomas/kong dependency-version: 1.15.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.66.0 to 1.67.0. - [Release notes](https://github.com/bufbuild/buf/releases) - [Changelog](https://github.com/bufbuild/buf/blob/main/CHANGELOG.md) - [Commits](bufbuild/buf@v1.66.0...v1.67.0) --- updated-dependencies: - dependency-name: github.com/bufbuild/buf dependency-version: 1.67.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Added a new binary file `pmm-managed-linux` for managing PMM operations. - Updated the `GetQanInsights` handler to return a 200 status with an empty analysis and `cached: false` on cache misses, improving user experience by avoiding misleading 404 errors. - Removed the ServiceNow ticket creation functionality from the QAN AI Insights page, streamlining the interface. - Introduced new utility functions for managing frontend tools, ensuring compatibility with legacy tool names and enhancing the overall user interaction with PMM. - Improved the layout and responsiveness of the Adre page components, ensuring better usability across different screen sizes. This update enhances the QAN insights functionality and user interface, providing a more intuitive experience for users interacting with PMM.
Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-0
Link to the Feature Build: SUBMODULES-0
If this PR adds, removes or alters one or more API endpoints, please review and add or update the relevant API documentation as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: