Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5040 +/- ##
==========================================
+ Coverage 47.76% 47.79% +0.03%
==========================================
Files 410 410
Lines 41967 41967
==========================================
+ Hits 20045 20059 +14
+ Misses 19944 19931 -13
+ Partials 1978 1977 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-13487
This pull request introduces a new Docker-based build pipeline for PMM (Percona Monitoring and Management), replacing the previous RPM/YUM-based installation approach. The changes include new Dockerfiles for building both server and client images, configuration files for environment and build context management, and updates to Ansible roles to reflect the new build process. The most important changes are grouped below.
New Docker-based Build Pipeline:
Dockerfile.server, which implements a multi-stage build for PMM Server, building all major components (pmm-managed, grafana, victoriametrics, dashboards, etc.) from source and copying the resulting binaries and assets directly into the runtime image, replacing RPM-based installation.Dockerfile.clientfor building the PMM Client image, installing necessary dependencies, extracting the client tarball, and setting up the runtime environment.Dockerfile.builderfor a Go build environment used in the pipeline.Build Context and Environment Management:
.dockerignoreto optimize Docker build context by excluding unnecessary files and directories..env.exampleto define environment variables for build-time configuration, including refs for all major dependencies and Minio S3 cache settings..gitignorefor pipeline-specific build outputs and cache files.Ansible and Legacy Build Cleanup:
pmm-imagesAnsible role that previously set up a local YUM repository and installed PMM Server components via RPMs, as binaries are now copied directly in the Dockerfile. [1] [2]Development Environment Improvements:
.devcontainer/setup.pyto allow bothtrustandscram-sha-256authentication methods inpg_hba.conffor PostgreSQL in the dev environment, improving developer convenience.