Do not return NULL when failing to parse a key provider config#562
Open
jeltz wants to merge 2 commits intopercona:mainfrom
Open
Do not return NULL when failing to parse a key provider config#562jeltz wants to merge 2 commits intopercona:mainfrom
jeltz wants to merge 2 commits intopercona:mainfrom
Conversation
The bad habit of returning NULL when we fail to parse a value from the key provider has a high risk of hiding bugs and data corrupt by just making it seem like the key provider never existed in the first place.
These two functions being separate made the code harder to read.
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (76.02%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 57.47% 57.51% +0.04%
==========================================
Files 68 68
Lines 10709 10703 -6
Branches 2640 2637 -3
==========================================
+ Hits 6155 6156 +1
+ Misses 3292 3288 -4
+ Partials 1262 1259 -3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bad habit of returning NULL when we fail to parse a value from the key provider has a high risk of hiding bugs and data corrupt by just making it seem like the key provider never existed in the first place.